Rending problems on Lumin

[StephenHodgson]

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

Lumin no longer renders properly (only left eye) after the updates to the Mixed Reality Standard shader.

I'm also getting these errors when building:

Shader error in 'Mixed Reality Toolkit/Wireframe': variable 'o' used without having been completely initialized at line 119 (on gles3)
Compiling Vertex program with STEREO_INSTANCING_ON
Platform defines: UNITY_NO_DXT5nm UNITY_NO_RGBM UNITY_ENABLE_REFLECTION_BUFFERS UNITY_FRAMEBUFFER_FETCH_AVAILABLE UNITY_NO_CUBEMAP_ARRAY UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_MOBILE UNITY_LIGHTMAP_DLDR_ENCODING

Shader error in 'Mixed Reality Toolkit/Wireframe': variable 'o' used without having been completely initialized at line 119 (on glcore)
Compiling Vertex program with STEREO_INSTANCING_ON
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_NO_CUBEMAP_ARRAY UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_LIGHTMAP_DLDR_ENCODING

To Reproduce

1. Switch to lumin build target
2. open build window
3. Build
4. See error

Expected behavior

Should render in both eyes

Actual behavior

Only renders in left eye

Screenshots

Your Setup (please complete the following information)

• Unity Version 2019.1.12f1
• XRTK Version 6e6ef36

Target Platform (please complete the following information)

• Lumin (Magic Leap)

[SimonDarksideJ]

The first part does worry me greatly, as to how that could even happen.
Hoping Ronald is back now to comment on the second part.

Likely we'll need to rollback the shaders based on this feedback

[mo-spatial]

FYI if you guys want the fix for the new MRTK standard shader to render in both eyes on Lumin you only need to make the following modifications:

[StephenHodgson]

Thanks!

Really we ought to update to the universal render pipeline as soon as we can through tbh.