Update Wireframe Shader to new MRTK standard

[SimonDarksideJ]

XRTK - Mixed Reality Toolkit Change Request

Overview

Update Wireframe Shader to new MRTK standard

Target of the change:

Is this enhancement for:

• Core (core framework, interfaces and definitions)

Changes:

Resolves #189

Breaking Changes:

Requires SDK update, to update materials to new shader

[StephenHodgson]

I explicitly made changes to the original mrtk shader to make variable usages clearer and cleaned up stuff. Did you just straight copy/paste?

[SimonDarksideJ]

If you made changes for clarity, better to handle this in the documentation, since we are unlikely to be modifying this functionality.

[StephenHodgson]

Did this work for Android?

[SimonDarksideJ]

It works for Android but not on the Quest or Go as they don't support Geometry shaders.
But the new shader doesn't cause an Android build to fail now and it doesn't crash on the device (just prevents rendering when in view)

[StephenHodgson]

Getting these shader errors now

Shader error in 'Mixed Reality Toolkit/Standard': Non system-generated input signature parameter (BLENDINDICES) cannot appear after a system generated value. at line 823 (on gles3)
Shader error in 'Mixed Reality Toolkit/Standard': Non system-generated input signature parameter (BLENDINDICES) cannot appear after a system generated value. at line 823 (on glcore)

[SimonDarksideJ]

Where are you getting those errors, and on which platform?
Do you want to raise an issue

[StephenHodgson]

It showed up when I was trying to update to 2019.2 on the lumin build target

[SimonDarksideJ]

So this doesn't happen in 2019.1, it's only just showed up in 2019.2 then. Oh shock horror... Because Unity :S

[StephenHodgson]

opened #263 in response to this.

[SimonDarksideJ]

Just spotted, thanks. Although concerned at how it seems to have gotten worse, may have to rollback till we have a fix

[StephenHodgson]

It's not the wireframe shader I'm worried about. It was the standard shader changes.

[StephenHodgson]

Let's roll it all back and just make changes to the wireframe shader

[SimonDarksideJ]

Agreed, let's roll back. But I'll remove the old wireframe shader from the SDK until we have a working solution. It'll have to be a project only thing until we have something that at least compiles on all platforms