Spatial Provider / Observer errors reported with only Core and SDK installed

[SimonDarksideJ]

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

If you start a new XRTK project with only Core and SDK installed, once you configure a scene you get several errors reported about the Spatial system

To Reproduce

1. Create a new project
2. Install XRTK-Core and SDK
3. Configure a Scene
4. See error

Expected behavior

No errors, or just a warning about using spatial on a non-spatial system

Actual behavior

4 Errors appear

Unable to register a service with a null concrete IMixedRealitySpatialObserverDataProvider type.
UnityEngine.Debug:LogError(Object)
XRTK.Services.MixedRealityToolkit:CreateAndRegisterService(Type, SupportedPlatforms, Object[]) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:852)
XRTK.Services.MixedRealityToolkit:InitializeServiceLocator() (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:434)
XRTK.Services.MixedRealityToolkit:ResetConfiguration(MixedRealityToolkitConfigurationProfile) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:117)
XRTK.Inspectors.MixedRealityToolkitInspector:OnInspectorGUI() (at Library/PackageCache/[email protected]/Inspectors/MixedRealityToolkitInspector.cs:99)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Failed to start Windows Mixed Reality Spatial Mesh Observer!
UnityEngine.Debug:LogError(Object)
XRTK.Services.MixedRealityToolkit:InitializeServiceLocator() (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:441)
XRTK.Services.MixedRealityToolkit:ResetConfiguration(MixedRealityToolkitConfigurationProfile) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:117)
XRTK.Inspectors.MixedRealityToolkitInspector:OnInspectorGUI() (at Library/PackageCache/[email protected]/Inspectors/MixedRealityToolkitInspector.cs:99)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Unable to register a service with a null concrete IMixedRealitySpatialObserverDataProvider type.
UnityEngine.Debug:LogError(Object)
XRTK.Services.MixedRealityToolkit:CreateAndRegisterService(Type, SupportedPlatforms, Object[]) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:852)
XRTK.Services.MixedRealityToolkit:InitializeServiceLocator() (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:434)
XRTK.Services.MixedRealityToolkit:ResetConfiguration(MixedRealityToolkitConfigurationProfile) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:117)
XRTK.Inspectors.MixedRealityToolkitInspector:OnInspectorGUI() (at Library/PackageCache/[email protected]/Inspectors/MixedRealityToolkitInspector.cs:99)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Failed to start Lumin Spatial Observer Data Provider!
UnityEngine.Debug:LogError(Object)
XRTK.Services.MixedRealityToolkit:InitializeServiceLocator() (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:441)
XRTK.Services.MixedRealityToolkit:ResetConfiguration(MixedRealityToolkitConfigurationProfile) (at Library/PackageCache/[email protected]/Services/MixedRealityToolkit.cs:117)
XRTK.Inspectors.MixedRealityToolkitInspector:OnInspectorGUI() (at Library/PackageCache/[email protected]/Inspectors/MixedRealityToolkitInspector.cs:99)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Your Setup (please complete the following information)

• Unity Version 2019.1.14
• XRTK Version Core - 0.1.20 / SDK 0.1.14

Target Platform (please complete the following information)

• Standalone

[StephenHodgson]

This isn't a bug, but it makes sense seeing as there aren't any platform specific spatial observers in the project if only the SDK and the Core are installed.

This will likely be something that would be a warning per #331. But it seems that you only did one core service this way (input service provider), but not all to be formatted in this way.

[SimonDarksideJ]

Then we should change this to check and be a warning too like the other warnings. I'll do a PR and update.

[StephenHodgson]

Still not sure I agree that it should be a warning though. If you're targeting a platform, and missing the platform dependencies that is a problem the developer needs to address it. As far as our default configuration tho, yeah it shouldn't be throwing errors at all unless you really are missing something.

[StephenHodgson]

I see the real issue now is the editor platform checking. These should have never ran in the editor anyway since their platform options exclude them from running in the editor.