This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Added check for data provider to fix #330 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| //If the DataProvider cannot be resolved, this is likely just a configuration / package missmatch. User simply needs to be warned, not errored. | ||
| if (controllerDataProvider.DataProviderType.Type == null) | ||
| { | ||
| Debug.LogWarning($"Could not load the configured provider ({controllerDataProvider.DataProviderName})\n\nThis is most likely because the XRTK UPM package for that provider is currently not registered\nCheck the installed packages in the Unity Package Manager\n\n"); |
There was a problem hiding this comment.
This isn't always the case. I'd drop the middle part but leave the last part.
There was a problem hiding this comment.
?? It's only a recommendation as to where to look. I'd rather keep the advice there to assist users to figure out how to diagnose warnings raised here
StephenHodgson
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
XRTK now issues a warning if a DataProvider cannot be initialised due to the dependant UPM package that contains that provider not being loaded (DataProviderType concrete type cannot be found)
Target of the change:
Is this enhancement for:
Changes: