This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Updated Awaiter.WaitUntil extension method with indefinite option #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDarksideJ
approved these changes
May 12, 2019
|
So by default this awaiter will timeout after 10 seconds, but there may be instances when people want to wait indefinitely. I didn't want to make it indefinite by default, nor break the existing functionality. As far as use cases? I'm not sure what you mean. Like adding example code showing it? |
|
More like a laymans terms example for why it might be used (guess you have one else you wouldn't have added it._ |
|
I'm not sure how I could simplify it anymore. Could you help? afaik it just waits forever, although in the future I'd love to add a cancellation token of some sort as an additional argument in an overload. |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
May 12, 2019
* added an indefinite wait until option * updated BaseEventSystem to use WaitUntil extension
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Needed the ability to wait indefinitely.
Target of the change:
Is this enhancement for: