This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Android oculus support #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Any" in configuration. Pointers are not yet however.
|
Please review changes, especially Inspector changes to supporting "Any" hand, may need to discuss how to add "other" options Visualisation is now working but no pointer? Need to also discuss the Visualization profile, as ONLY controllers with a custom profile are now supported. If a controller override isn't available, it doesn't work. This isn't as intended, as the overrides are meant to be overrides, with the defaults taking precedent if not provided. |
...ges/com.xrtk.core/Inspectors/Profiles/MixedRealityControllerVisualizationProfileInspector.cs
Outdated
Show resolved
Hide resolved
...Packages/com.xrtk.core/Definitions/Controllers/MixedRealityControllerVisualizationProfile.cs
Outdated
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/OpenVR/OculusGoController.cs
Outdated
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/OpenVR/OpenVRDataProvider.cs
Show resolved
Hide resolved
…AndroidOculusSupport
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseController.cs
Outdated
Show resolved
Hide resolved
SimonDarksideJ
added
Ready for review
|
Final fixes / tests done. Ready for review / merge |
jshowacre
reviewed
Jun 4, 2019
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/OpenVR/OculusGoController.cs
Outdated
Show resolved
Hide resolved
jshowacre
approved these changes
Jun 5, 2019
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseController.cs
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/OpenVR/OpenVRDataProvider.cs
Show resolved
Hide resolved
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jul 15, 2019
* Initial Commit of Oculus Go OpenVR support on Android * Controller visualization now working, updated handedness to support "Any" in configuration. Pointers are not yet however. * Updated comments and improved the Oculus go inspector * CHanged using Any to Both hands. Meaning a controller could be in either hand * Updated missing ref from Any to Both * Finalised testing / configuration for oculus Go OPENVR support * If only for the but..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Updating OpenVR platform to support Android / Oculus devices, including "Any" handedness controllers
Target of the change: