This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Visualisation fix for #233 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDarksideJ
changed the title
|
In testing, found an issue with assigning models. A) The Unity API must have updated as the previous Prefab check was failing (model could not be assigned) - Fixed |
Included global pointer parameter
… as Press interactions were mapped to Axis instead of button
…into dev/visualisation
|
All issues resolved, including the OculusTouch pointer issue which was mapped incorrectly to an axis instead of a button |
wassx
reviewed
Jul 10, 2019
...Packages/com.xrtk.core/Definitions/Controllers/MixedRealityControllerVisualizationProfile.cs
Show resolved
Hide resolved
wassx
reviewed
Jul 10, 2019
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseController.cs
Show resolved
Hide resolved
wassx
approved these changes
Jul 11, 2019
jshowacre
reviewed
Jul 11, 2019
...Packages/com.xrtk.core/Definitions/Controllers/MixedRealityControllerVisualizationProfile.cs
Show resolved
Hide resolved
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jul 15, 2019
* Initial check-in of Visualisation fix for #233 * Reordered the visualisation logic. Included global pointer parameter * Updated Default mapping definitions for Touch, resolves pointer issue as Press interactions were mapped to Axis instead of button * Update spelling and restructure elements * Minor mapping change after review * Updated Mapping layout * Review comments addressed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Initial check-in of Visualisation fix for #233