This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fix to resolve Git Tag sorting issue #300 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based on a 3 digit version code. Select the actual latest version based on: x.x.x version number Previously, last was determined by the double value parsed value, which is incorrectly sorted by .NET. Now sorts by each individual version identifier to locate the latest.
SimonDarksideJ
added
Bug
StephenHodgson
approved these changes
Sep 3, 2019
| @@ -209,7 +209,8 @@ internal static async void ValidatePackages() | |||
|
|
|||
| private static async Task AddPackageAsync(MixedRealityPackageInfo packageInfo) | |||
| { | |||
| var tag = (await GitUtilities.GetAllTagsFromRemoteAsync(packageInfo.Uri)).LastOrDefault(); | |||
| var versionSeperator = new char[] { '.' }; | |||
There was a problem hiding this comment.
This could be a readonly field in the class so we don't allocate it every time we add a package.
StephenHodgson
approved these changes
Sep 3, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
* fix to resolve #300, properly sorts the tag versions returned by Git based on a 3 digit version code. Select the actual latest version based on: x.x.x version number Previously, last was determined by the double value parsed value, which is incorrectly sorted by .NET. Now sorts by each individual version identifier to locate the latest. * Restored missing variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
fix to resolve #300, properly sorts the tag versions returned by Git based on a 3 digit version code. Select the actual latest version based on:
x.x.x version number
Previously, last was determined by the double value parsed value, which is incorrectly sorted by .NET. Now sorts by each individual version identifier to locate the latest.
Target of the change:
Is this enhancement for:
Changes:
Updates Git Tag version sort to sort by each individual version identifier