This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Updated concept of "Configuration Profile" and Inspector Cleanup #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some confusion about the difference between a configurations and profiles, so this rename should help clear that up
StephenHodgson
added
the
Ready for review
jshowacre
changed the title
StephenHodgson
commented
Apr 1, 2020
XRTK-Core/Packages/com.xrtk.core/Services/MixedRealityToolkit.cs
Outdated
Show resolved
Hide resolved
|
What about |
jshowacre
reviewed
Apr 1, 2020
XRTK-Core/Packages/com.xrtk.core/Definitions/MixedRealityToolkitRootProfile.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
added
In Progress
FejZa
previously approved these changes
Apr 1, 2020
Updated all the inspectors to use RenderHeader where appropriate
StephenHodgson
added
Ready for review
|
Okay this Pull Request is ready |
StephenHodgson
changed the title
jshowacre
reviewed
Apr 1, 2020
XRTK-Core/Packages/com.xrtk.core/Definitions/MixedRealityToolkitRootProfile.cs
Show resolved
Hide resolved
jshowacre
previously approved these changes
Apr 1, 2020
SimonDarksideJ
previously approved these changes
Apr 1, 2020
StephenHodgson
dismissed stale reviews from SimonDarksideJ and jshowacre
via
b37e294
|
Sorry guys one last review. I had to merge in the upstream changes |
FejZa
approved these changes
Apr 1, 2020
SimonDarksideJ
approved these changes
Apr 1, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Apr 1, 2020
* Renamed the MixedRealityConfigurationProfile to MixedReaklityRootProfile There was some confusion about the difference between a configurations and profiles, so this rename should help clear that up * Update XRTK-Core/Packages/com.xrtk.core/Services/MixedRealityToolkit.cs * Removed more references to configuration when we meant profile * updated docs some more * updated camera profile inspector * updated pointer profile inspector * Updated service provider profile inspector * fixed configuration profile serialized field reference * updated gesture profile inspector * updated input system profile inspector * Updated all the inspectors with nameof usages Updated all the inspectors to use RenderHeader where appropriate * removed unused using statement * updated sdk checkout * updated wmr checkout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
There was some confusion about the difference between a configurations and profiles, so this rename should help clear that up.
I also updated all the profile inspectors to property utilize
nameof(serializedProperty)and use a common header path so updating it to use breadcrumb later can be easier.Breaking Changes
MixedRealityConfigurationProfile->MixedRealityTookitRootProfileMixedRealityToolkit.ResetConfiguration(MixedRealityConfigurationProfile profile)->MixedRealityToolkit.ResetProfile(MixedRealityTookitRootProfile profile)IMixedRealityServiceConfiguration.ConfigurationProfile->IMixedRealityServiceConfiguration.Profile