This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Misc changes to pose processor and hand controller #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesthetic and spell checking in hand controller
StephenHodgson
added
the
Ready for review
FejZa
approved these changes
May 28, 2020
FejZa
added a commit
that referenced
this pull request
Sep 22, 2020
* Delete baked lighting settings for base * Fix ControllerPopupWindow NRE * Implement internal is grabbing update * Disable hand meshing by default and assign tracked poses to test profile * Add IsValidCollision extension to colliders * Feature/pni change requests (#577) * Update ColliderExtensions.cs * Update CollisionExtensions.cs * updated submodules * updated sdk * updated sdk * Cleanup namespace * Better fallback pointer pose calculation * Introduce hand rendering mode * Implement runtime rendering mode switch * Update submodules * Start new hands examples room * Add canvas UI and 3D Buttons station * Show button stations result * Implement set rendering mode station * Added more stations * Update submodules * updated wmr checkout * updated sdk * Update submodules * Add additive scene loader for hands demo scene * Restore base scene * Add simple physics demo station * Cleanup namespace * Cleanup hand examples a bit * Update stations * Implement runtime bounds mode selection * Update submodules * Update Ultraleap checkout * Update physics station * Update submodule * Update submodule * Fix UWP certficate error * Moved examples to examples repo * reset editor window options for hands * Implement pinch strength * Add pinch strength to hand controller interface * Update submoduules * Update SDK * Use array instead of list for tracked poses * Restructure pose recognition code * Improved variable naming * Add root pose to hand data * Set root pose for simulation * Fix joint rotations * Update SDK * Remove base converter and introduce Post Processor * Update data provider to use post processor * Optimize recognition * Introduce grip strength * Enable setters for post processor * Minor refactoring in post processor * Removed NONE joint * Rename joints * Update submodules * Extend default hand mappings * Sync simulation profiles * Reset popup window options for hands * Hand input and poses change request (#616) * Cleaned up RecordedHandJoint(s) to remove reference values removed null unity object lifetime bypass added better exceptions when starting simulated hand controller data provider and Simulated hand data converter * fixed missing line * updated sdk checkout * Implement grip pose * Adjust processor to joint enum renamings * updated sdk checkout * Introduce hand finger enum * Rename pose recognizer and implement frame throttle * Minor docs update * Implement finger curls * Add Oculus (Desktop) package back in for now * Disable debug log for grip calculations * updated tracked pose processor compare (#617) aesthetic and spell checking in hand controller Co-authored-by: Dino Fejzagic <[email protected]> * Implement IMixedRealityHandController.TryGetFingerCurlStrength * Update SDK * Disable recognition for now * Add index curl constraint to isgripping detection * updated sdk checkout * updated SDK * updated sdk checkout * Implement recorded pose baking and update inspector * Update SDK * Remove handedness from hand data * Update Oculus * Fix baked data not persisted * Update SDK * Fix pose recognizer handedness issue * Improve pose processor * Fix IsPointing set to false when pinching * Update submodules * Update examples checkout * Do not pass tracked pose scriptable object outside of data provider * Update examples * Update examples * Fix potential NRE Co-authored-by: Stephen Hodgson <[email protected]> * Fix potential casting error Co-authored-by: Stephen Hodgson <[email protected]> * Fix formatting * Use for instead of foreach * Revert metro package version * Rename HandControllerPoseDefinition to HandControllerPoseProfile * Revert to ReordableList for tracked poses * Change HandData to be a struct * Update submodule * Update example module * Fix invalid simulated hand position when camera rotation is changed * Fix generic pointer pose invalid when camera rotated * Remove redundant properties in hand mesh data * Update submodules * Only update hand state if hand is tracked * Remove obsolete pose extensions * Introduce hand utilities for pose estimation * Update submodules * Implement TryGetHandMeshData * Remove HandData input event * Update submodule * Update submodules * Implement relativeTo paramter for TryGetJointPose * Fix IsPointing * Use TrackingState instead of bool for tracking state * Fix missed occurence of IsTracked * Update Oculus * Fix pointer pose * Update Oculus * Fix fallback pointer pose * Fix pose recognizer left/right issue * Update submodules * Remove tracked pose mapping (coming back later) * Fix hand velocity calculation * Fix local to world joint translation * Fix simulation mappings * Fix IsPointing after teleport * Update submodule * Fix simulated hand not reset on tracking loss * Fix simulated hand position after teleport * Update SDK * Update SDK * Update examples module * fixed some typos * updated oculus checkout * Update example checkout * Reset hand controller options window * Update submodules * fixed submodule checkouts * Remove tracked poses from hand data provider interface * Cache bounds arrays * Allow a bit more tolerance wit IsPointing * Update submodules * Update example * Update modules * Update submodules * Update oculus * Update WMR * Clean up gizmo meshes * Remove duplicate vertices in gizmo meshes * Update submodules and wmr package * Only apply default head height if not managed by device * Update submodules * Introduce IHandDataPostProcessor * Update submodules * Update WMR submodule Co-authored-by: Stephen Hodgson <[email protected]> Co-authored-by: Simon (Darkside) Jackson <[email protected]>
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Delete baked lighting settings for base * Fix ControllerPopupWindow NRE * Implement internal is grabbing update * Disable hand meshing by default and assign tracked poses to test profile * Add IsValidCollision extension to colliders * Feature/pni change requests (#577) * Update ColliderExtensions.cs * Update CollisionExtensions.cs * updated submodules * updated sdk * updated sdk * Cleanup namespace * Better fallback pointer pose calculation * Introduce hand rendering mode * Implement runtime rendering mode switch * Update submodules * Start new hands examples room * Add canvas UI and 3D Buttons station * Show button stations result * Implement set rendering mode station * Added more stations * Update submodules * updated wmr checkout * updated sdk * Update submodules * Add additive scene loader for hands demo scene * Restore base scene * Add simple physics demo station * Cleanup namespace * Cleanup hand examples a bit * Update stations * Implement runtime bounds mode selection * Update submodules * Update Ultraleap checkout * Update physics station * Update submodule * Update submodule * Fix UWP certficate error * Moved examples to examples repo * reset editor window options for hands * Implement pinch strength * Add pinch strength to hand controller interface * Update submoduules * Update SDK * Use array instead of list for tracked poses * Restructure pose recognition code * Improved variable naming * Add root pose to hand data * Set root pose for simulation * Fix joint rotations * Update SDK * Remove base converter and introduce Post Processor * Update data provider to use post processor * Optimize recognition * Introduce grip strength * Enable setters for post processor * Minor refactoring in post processor * Removed NONE joint * Rename joints * Update submodules * Extend default hand mappings * Sync simulation profiles * Reset popup window options for hands * Hand input and poses change request (#616) * Cleaned up RecordedHandJoint(s) to remove reference values removed null unity object lifetime bypass added better exceptions when starting simulated hand controller data provider and Simulated hand data converter * fixed missing line * updated sdk checkout * Implement grip pose * Adjust processor to joint enum renamings * updated sdk checkout * Introduce hand finger enum * Rename pose recognizer and implement frame throttle * Minor docs update * Implement finger curls * Add Oculus (Desktop) package back in for now * Disable debug log for grip calculations * updated tracked pose processor compare (#617) aesthetic and spell checking in hand controller Co-authored-by: Dino Fejzagic <[email protected]> * Implement IMixedRealityHandController.TryGetFingerCurlStrength * Update SDK * Disable recognition for now * Add index curl constraint to isgripping detection * updated sdk checkout * updated SDK * updated sdk checkout * Implement recorded pose baking and update inspector * Update SDK * Remove handedness from hand data * Update Oculus * Fix baked data not persisted * Update SDK * Fix pose recognizer handedness issue * Improve pose processor * Fix IsPointing set to false when pinching * Update submodules * Update examples checkout * Do not pass tracked pose scriptable object outside of data provider * Update examples * Update examples * Fix potential NRE Co-authored-by: Stephen Hodgson <[email protected]> * Fix potential casting error Co-authored-by: Stephen Hodgson <[email protected]> * Fix formatting * Use for instead of foreach * Revert metro package version * Rename HandControllerPoseDefinition to HandControllerPoseProfile * Revert to ReordableList for tracked poses * Change HandData to be a struct * Update submodule * Update example module * Fix invalid simulated hand position when camera rotation is changed * Fix generic pointer pose invalid when camera rotated * Remove redundant properties in hand mesh data * Update submodules * Only update hand state if hand is tracked * Remove obsolete pose extensions * Introduce hand utilities for pose estimation * Update submodules * Implement TryGetHandMeshData * Remove HandData input event * Update submodule * Update submodules * Implement relativeTo paramter for TryGetJointPose * Fix IsPointing * Use TrackingState instead of bool for tracking state * Fix missed occurence of IsTracked * Update Oculus * Fix pointer pose * Update Oculus * Fix fallback pointer pose * Fix pose recognizer left/right issue * Update submodules * Remove tracked pose mapping (coming back later) * Fix hand velocity calculation * Fix local to world joint translation * Fix simulation mappings * Fix IsPointing after teleport * Update submodule * Fix simulated hand not reset on tracking loss * Fix simulated hand position after teleport * Update SDK * Update SDK * Update examples module * fixed some typos * updated oculus checkout * Update example checkout * Reset hand controller options window * Update submodules * fixed submodule checkouts * Remove tracked poses from hand data provider interface * Cache bounds arrays * Allow a bit more tolerance wit IsPointing * Update submodules * Update example * Update modules * Update submodules * Update oculus * Update WMR * Clean up gizmo meshes * Remove duplicate vertices in gizmo meshes * Update submodules and wmr package * Only apply default head height if not managed by device * Update submodules * Introduce IHandDataPostProcessor * Update submodules * Update WMR submodule Co-authored-by: Stephen Hodgson <[email protected]> Co-authored-by: Simon (Darkside) Jackson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview