Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Included platform prefabs in the Symbolic links for dev branch #709

Closed
wants to merge 1 commit into from

Conversation

SimonDarksideJ
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ commented Dec 10, 2020

XRTK - Mixed Reality Toolkit Pull Request

Overview

Included platform prefabs in the Symbolic links for dev branch

Changes

Symbolic links updated to include new package hidden folders

Related changes

@SimonDarksideJ SimonDarksideJ requested a review from FejZa December 10, 2020 13:26
@SimonDarksideJ SimonDarksideJ self-assigned this Dec 10, 2020
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be prefabs in the platform packages

@SimonDarksideJ
Copy link
Contributor Author

There should not be dependencies between the Platforms and another package, e.g. the SDK. This breaks platforms.
We can work on a better solution for 0.3

@StephenHodgson
Copy link
Contributor

I'd much rather see a dependency on the SDK then having to manage duplicate assets across all the platforms

@SimonDarksideJ
Copy link
Contributor Author

If you can resolve #706 in short order, we can reevaluate the way forward. Else we will need to accept this approach in the short term to lead to a future workable arrangement

@SimonDarksideJ SimonDarksideJ deleted the fix/PlatformDependancies branch December 16, 2020 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants