This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fix NRE in EditorActiveProfileChangeHandler #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NREs were thrown in the handler if no active profile was set.
FejZa
added
the
Ready for review
StephenHodgson
approved these changes
Jan 15, 2021
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jan 15, 2021
NREs were thrown in the handler if no active profile was set.
| @@ -18,7 +18,7 @@ static EditorActiveProfileChangeHandler() | |||
|
|
|||
| private static void EditorApplication_hierarchyChanged() | |||
| { | |||
| if (!MixedRealityToolkit.Instance.IsNull()) | |||
| if (!(MixedRealityToolkit.Instance.IsNull() || MixedRealityToolkit.Instance.ActiveProfile.IsNull())) | |||
There was a problem hiding this comment.
@FejZa this makes the xrtk auto-configure
There was a problem hiding this comment.
Ok thanks. I'll check it but not sure how this can be the cause of it?? Weird world.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Fixes the NREs thrown in the build's test steps when no active profile was configured for the toolkit.
NREs were thrown in the handler if no active profile was set.