This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Dev/bounding box accessors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bounding center not being calculated correctly. - Added manipulation handler as a required component to the bounding box. - Disabled colliders on the bounding box and it's proxy as we're performing manipulations.
SimonDarksideJ
suggested changes
Aug 6, 2019
XRTK.SDK/Packages/com.xrtk.sdk/Features/Input/Handlers/ManipulationHandler.cs
Outdated
Show resolved
Hide resolved
…lay flags to true - Fixed wireframe padding growing each time the bounding box was enabled/disabled
SimonDarksideJ
previously approved these changes
Aug 6, 2019
SimonDarksideJ
previously approved these changes
Aug 6, 2019
…o that we don't have to disable the colliders Updated Bounding Boxes scale constraints to use the manipulation handler's since it's a required component
fixed popping when starting a hold fixed colliders still being active on bounding box when rendering was disabled.
SimonDarksideJ
approved these changes
Aug 9, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Aug 13, 2019
* added public accessors for setting bounding box properties. * show rotate handles if set * - Fixed handle visibility when using cardinal axes. - Fixed bounding center not being calculated correctly. - Added manipulation handler as a required component to the bounding box. - Disabled colliders on the bounding box and it's proxy as we're performing manipulations. * Don't use the offset if the object's position is at zero * - Ensure we enabled display handles if setting any of the handle display flags to true - Fixed wireframe padding growing each time the bounding box was enabled/disabled * only enable the bounds collider when rig is active * Disable link colliders. We don't need them * Ignore the manipulation target while we're performing our transform so that we don't have to disable the colliders Updated Bounding Boxes scale constraints to use the manipulation handler's since it's a required component * removed unused using statement * Added spatial mesh visibility options while manipulating an object * revert removal of extensions * use the manipulation target to determine the layer * added pointer offset rotation/scaling to manipulation handler fixed popping when starting a hold fixed colliders still being active on bounding box when rendering was disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added accessors to bounding box to easier customization at runtime.
Changes