Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file health check similar to folder health check #2027

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

michaelmairegger
Copy link
Contributor

This health check allows to check fo existing files similar to FolderHealthCheck

services.AddHealthChecks()
    .AddFile(setup => setup.AddFile("FileUnderTest")), tags: new string[] { "file" });

@sungam3r
Copy link
Collaborator

sungam3r commented Dec 3, 2023

@michaelmairegger Thanks. I'm fine to merge after you add xml comments for new public APIs and some notes in README.

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c000704) 69.24% compared to head (55eb377) 69.35%.
Report is 19 commits behind head on master.

Files Patch % Lines
src/HealthChecks.System/FileHealthCheck.cs 80.00% 4 Missing and 1 partial ⚠️
src/HealthChecks.System/FileHealthCheckOptions.cs 60.00% 4 Missing ⚠️
...ncyInjection/SystemHealthCheckBuilderExtensions.cs 87.50% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
+ Coverage   69.24%   69.35%   +0.10%     
==========================================
  Files         176      178       +2     
  Lines        4582     4633      +51     
  Branches      445      452       +7     
==========================================
+ Hits         3173     3213      +40     
- Misses       1305     1313       +8     
- Partials      104      107       +3     
Flag Coverage Δ
System 42.56% <78.43%> (+5.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelmairegger
Copy link
Contributor Author

@sungam3r The xml comment is already existing. The new api for files is commented the same as the existing api for folders.

@sungam3r sungam3r merged commit 2aad15f into Xabaril:master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants