New special duration: RestComplete, NextD20Roll deletion fixes, Effect name fix #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanferrer
reviewed
Oct 7, 2024
| if ( | ||
| effect.changes.find(e => e.key.includes('system.bonuses.attack.boons.all')) || !effect.changes.length || | ||
| effect.changes.find(e => e.key.includes(`system.bonuses.attack.boons.${nAttackAttribute}`)) || | ||
| effect.changes.find(e => e.key.includes(`system.bonuses.attack.boons.weapon`)) |
There was a problem hiding this comment.
Maybe needs to be added for spells as well?
| if (specialDuration === 'NextD20Roll') { | ||
| let nAttackAttribute = attackAttribute.length ? attackAttribute : 'None' | ||
| if ( | ||
| effect.changes.find(e => e.key.includes('system.bonuses.attack.boons.all')) || !effect.changes.length || |
There was a problem hiding this comment.
Probably best to move the end !effect.changes.length === 0 to the top or the bottom. Same for lines 515, 598, 697 and 802.
There was a problem hiding this comment.
Code checks the same bonuses what each function rollItem/Talent/Weapon/Spell uses, so If you set a bonus to system.bonuses.attack.boons.spell effect will be removed when spell casted.
Same as weapon attack checks only for system.bonuses.attack.boons.${AttackAttribute}, system.bonuses.attack.boons.all and system.bonuses.attack.boons.all and not for system.bonuses.attack.boons.spell.
That is the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: New special duration: RestComplete
Fixed: Incorrect effect name, when applying effect on multiple target.
Fixed: EndOfTheRound ignores system.bonuses.attack.boons.attribute.
Fixed: NextD20Roll ignores system.bonuses.attack.boons.attribute, system.bonuses.attack.boons.weapon and system.bonuses.attack.boons.spell on deletion.