-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum gate models for IR integration #16
Conversation
Thanks for the review, @josh146! Let me know what you think of the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here. I think it can be left for now, but at some later date I'd love to see |0><0|
and |1><1|
projectors, as well as controlled arbitrary (non-)unitary gates. Though, I think what you have here looks great, and I'm happy to see it go in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mandrenkov!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks like an amazing addition! 😍 🚀
For improvement (maybe in a subsequent PR even), the docstrings could be adjusted to adhere to convention. Was also curious about each CV gate getting a dedicated cutoff
value, not sure if this can be easily kept track of for the entire tensor network (maybe missing something).
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>
Co-authored-by: antalszava <[email protected]>
Context:
An abstraction for quantum gates can be useful for building a Jet interpreter for XIR scripts if it supports converting a unitary matrix into a
Tensor
instance.Description of the Change:
jet
Python package now includes a baseGate
class for modelling quantum gates.Gate
classes for modelling CV and qubit gates are now available.__init__.py
have been moved to a separatefactory.py
module.Benefits:
jet
package and convert them intoTensor
objects.Possible Drawbacks:
None.
Related GitHub Issues:
None.