Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum circuit and state models for IR integration #21
Quantum circuit and state models for IR integration #21
Changes from all commits
e26a180
ba4be4d
5c82fc5
20ff84c
a250727
c6da8b8
a6cc282
a75f654
09a01c0
471c54a
4d495e1
a8263ad
1f3c921
b4d59ad
42d13f0
5e09908
2d08472
8c5475a
97eed02
05b7c08
95685fd
71b6622
01ae9b9
b292e52
c102416
c86b04a
6218b5a
477f548
17da911
48b82b7
97a31f7
bf59af7
5ee13e4
6bc04b8
9c99b6a
19e7cc0
a1ba8ff
5445412
0fd4c5b
dc54995
aab1c7c
aac1fab
e878297
24f0ba7
a26448e
08c7975
a99a0b0
0604c8b
56c6ac5
a389e28
1c7edff
1f833d1
7d1e281
033dba6
a1e701f
2a997c1
2722053
65d81a8
4bd800e
4119651
db43ea3
82bfff8
f05897f
6ad309b
fb10633
b74c143
9c42cd7
0ceb250
748d523
9e95792
7e3b55b
8b349d4
91a0cb4
0750650
e4467fc
bcf086d
686c462
ccfb710
c68c08b
886a513
71ac471
1906e81
1485be7
59257e8
55af49d
bf18d71
e7f9a03
c91ceb5
dc4e049
4335a1f
4cf73bc
f461881
e80f43a
c6d0e32
00b063d
67051bf
da78c9e
d2b7a0f
2617d2a
c9e1a87
3776822
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor, but this logic makes me wonder if
Wire
andQudit
should be the same object?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not sure how that would work: a wire represents an ordered collection of tensor indices while a qudit represents a quantum state. The only commonality between the two is that qudits are placed at either end of a wire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my confusion here stems more from the terminology. In other frameworks, Qubit/Wire/Mode are essentially synonyms describing the same object. When you see Qubit/Qudit in a codebase, I expect it to be a book-keeping object, rather than something that describes the state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's understandable. Do you think the
Qudit
class should be renamed toQuditState
or something similar?