-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum gate factory for IR integration #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandrenkov
added
enhancement ✨
New feature or request
code quality 🎓
Improvements to code quality
labels
Jun 10, 2021
mlxd
reviewed
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just added comments, but feel free to ignore these.
mlxd
reviewed
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from me --- great job on this!
mlxd
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR is part of an ongoing series of changes to integrate the XIR with Jet. Implementing the factory method pattern for the
Gate
class can streamline the interpretation of gate application statements in XIR scripts.Description of the Change:
GateFactory
class has been added to create instances ofGate
subclasses by name.Benefits:
Gate
subclass.Possible Drawbacks:
Gate
subclasses will need to be decorated with a call to@GateFactory.register
to be used with the Jet-IR interpreter; this introduces a small implementation burden.Related GitHub Issues:
None.