Add Jet paper benchmarking samples and submission scripts #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandrenkov
reviewed
Jul 5, 2021
There was a problem hiding this comment.
I think we should be OK to merge once we've finalized the benchmarks in the paper; the important thing is to enable others to reproduce the results in the paper.
As a side note, is examples/paper_benchmarks/CPU/cot_cpu_m10/niagara_submit.slurm meant to be empty?
Mandrenkov
approved these changes
Jul 16, 2021
Co-authored-by: Mikhail Andrenkov <[email protected]>
Co-authored-by: Mikhail Andrenkov <[email protected]>
Co-authored-by: Mikhail Andrenkov <[email protected]>
Co-authored-by: Mikhail Andrenkov <[email protected]>
|
Benchmarks now will pull down the 0.2.0 tag when ready. I'll merge this shortly, and we can tag when pushed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: All data included in the Jet paper must be reproducible by the repo main branch. This PR will include all necessary scripts and data to reproduce all such benchmarks in the paper.
Description of the Change: An
examplesdirectory is added, housing the different scripts and benchmarking examples for the Niagara HPC system form=10with and without slicing, andm=12with a fixed number of slices.Benefits: All data are directly reproducible by any user or researcher.
Possible Drawbacks: The submission scripts for Niagara are guaranteed to work while the system is online. Minimal medications may be required to run on additional systems.
Related GitHub Issues: None.