-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove XIR files and clean up documentation #69
Conversation
Test Report (C++) on Ubuntu 1 files ±0 1 suites ±0 0s ⏱️ ±0s Results for commit 9d2b62b. ± Comparison against base commit cb4ab41. This pull request removes 318 and adds 318 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Report (Python) on Ubuntu 1 files ± 0 1 suites ±0 5s ⏱️ -2s Results for commit 9d2b62b. ± Comparison against base commit cb4ab41. This pull request removes 556 and adds 300 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mandrenkov! I just had a few questions about the links in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Mandrenkov! 💯 Nothing major blocking, will approve as soon as the comments from myself and Tom are addressed. 🙂
Co-authored-by: Tom Bromley <[email protected]>
Co-authored-by: Theodor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
Thanks, @thisac and @trbromley! |
Context:
The XIR is now available on PyPI and is being actively maintained in a different repository.
After this PR is merged, Jet can be released on PyPI.
Description of the Change:
requirements.txt
file as per the PyPA guidelines.get_xir_library()
toget_xir_manifest()
and added declarations for the supported outputs.Benefits:
Possible Drawbacks:
Related GitHub Issues:
None.