Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exception details instead of generic fail message #73

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

RadWolfie
Copy link
Contributor

Include stack trace and message for a better understanding of the origin of faulty code.

This was not directly to improve #67 issue readability. But for myself encountered an issue with major work in progress to support the future extended information option.

The function I had worked on does work correctly. Except, this pull request was not tested with the reused code but with fewer details.

@RadWolfie RadWolfie force-pushed the expand-exception-message branch from 2be7ac0 to 5e49deb Compare September 23, 2024 09:02
@RadWolfie RadWolfie marked this pull request as ready for review December 13, 2024 18:14
@RadWolfie
Copy link
Contributor Author

Since the issue didn't return from #67, I went ahead and changed this to ready for review/merge.

Here's an example below when I had the executable denied to be executed by myself.

(These messages are also written to the application log file)

stack[0]     : java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
stack[1]     : java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
stack[2]     : xbeloader.XbeXbSymbolDatabaseAnalyzer.added(XbeXbSymbolDatabaseAnalyzer.java:110)
stack[3]     : ghidra.app.plugin.core.analysis.AnalysisScheduler.runAnalyzer(AnalysisScheduler.java:186)
stack[4]     : ghidra.app.plugin.core.analysis.AnalysisTask.applyTo(AnalysisTask.java:39)
stack[5]     : ghidra.app.plugin.core.analysis.AutoAnalysisManager$AnalysisTaskWrapper.run(AutoAnalysisManager.java:686)
stack[6]     : ghidra.app.plugin.core.analysis.AutoAnalysisManager.startAnalysis(AutoAnalysisManager.java:786)
stack[7]     : ghidra.app.plugin.core.analysis.AutoAnalysisManager.startAnalysis(AutoAnalysisManager.java:665)
stack[8]     : ghidra.app.plugin.core.analysis.AutoAnalysisManager.startAnalysis(AutoAnalysisManager.java:630)
stack[9]     : ghidra.app.plugin.core.analysis.AnalysisBackgroundCommand.applyTo(AnalysisBackgroundCommand.java:58)
stack[10]     : ghidra.framework.plugintool.mgr.BackgroundCommandTask.run(BackgroundCommandTask.java:103)
stack[11]     : ghidra.framework.plugintool.mgr.ToolTaskManager.run(ToolTaskManager.java:334)
stack[12]     : java.base/java.lang.Thread.run(Thread.java:833)
message      : Cannot run program "C:\Users\<username>\.ghidra\.ghidra_11.0.3_PUBLIC\Extensions\ghidra-xbe\os\win_x86_64\XbSymbolDatabaseTool.exe": CreateProcess error=5, Access is denied

@mborgerson mborgerson merged commit f073b09 into XboxDev:master Dec 13, 2024
4 checks passed
@RadWolfie RadWolfie deleted the expand-exception-message branch December 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants