Feature/refactor dto #16

codecakes · 2022-07-12T20:54:37Z

No description provided.

…d unnecessary code in init. Upgraded pylint version. generated new pylintrc

… pylint rules

sourcery-ai · 2022-07-12T20:54:42Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 2.56%.

Quality metrics	Before	After	Change
Complexity	0.63 ⭐	1.05 ⭐	0.42 👎
Method Length	24.09 ⭐	28.10 ⭐	4.01 👎
Working memory	4.71 ⭐	5.11 ⭐	0.40 👎
Quality	91.20% ⭐	88.64% ⭐	-2.56% 👎

Other metrics	Before	After	Change
Lines	620	806	186

Changed files	Quality Before	Quality After	Quality Change
registrations/domain/dto.py	85.25% ⭐	72.83% 🙂	-12.42% 👎
registrations/domain/hospital/registration.py	92.10% ⭐	90.75% ⭐	-1.35% 👎
registrations/domain/location/location.py	90.98% ⭐	90.98% ⭐	0.00%
registrations/domain/repo/registration_repo.py	97.61% ⭐	97.21% ⭐	-0.40% 👎
registrations/domain/services/application_services.py	74.16% 🙂	89.68% ⭐	15.52% 👍
registrations/domain/services/hospital_registration_services.py	93.39% ⭐	93.30% ⭐	-0.09% 👎
registrations/infrastructure/adapters/api/routers/register_hospital.py	76.77% ⭐	69.34% 🙂	-7.43% 👎
registrations/utils/enum_utils.py	96.34% ⭐	98.34% ⭐	2.00% 👍
tests/conftest.py	94.41% ⭐	90.24% ⭐	-4.17% 👎
tests/test_registrations.py	92.61% ⭐	89.56% ⭐	-3.05% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
registrations/domain/dto.py	validate_name	5 ⭐	68 🙂	13 😞	63.50% 🙂	Extract out complex expressions
registrations/infrastructure/adapters/api/routers/register_hospital.py	register_hospital_center	4 ⭐	58 ⭐	11 😞	69.34% 🙂	Extract out complex expressions
tests/conftest.py	registration_entry_manual_verification	0 ⭐	41 ⭐	15 😞	70.07% 🙂	Extract out complex expressions
tests/conftest.py	registration_entry_unclaimed	0 ⭐	33 ⭐	12 😞	75.62% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sonatype-lift · 2022-07-12T20:56:37Z

registrations/domain/dto.py

+            raise ValueError(f"Invalid name: {name}. Not enough characters.")
+        return name
+
+    @pydantic.root_validator


Invalid decoration: While applying decorator pydantic.root_validator

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

… responsibility of HospitalRegistrationApplicationService calling domain service

sonatype-lift · 2022-07-14T01:58:07Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute hospital_contact_number is declared in class ToHospitalRegistrationEntry to have type str but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-14T01:58:09Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute name is declared in class ToHospitalRegistrationEntry to have type str but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-14T01:58:10Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute verified_status is declared in class ToHospitalRegistrationEntry to have type Optional[str] but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-14T01:58:12Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute address is declared in class ToHospitalRegistrationEntry to have type Address but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-14T01:58:13Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute key_contact is declared in class ToHospitalRegistrationEntry to have type Optional[RegisterKeyContact] but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-14T01:58:15Z

registrations/domain/dto.py

@@ -21,7 +24,7 @@ class RegisterKeyContact(
    email: Optional[pydantic.EmailStr]


-class HospitalRegistrationEntry(
+class ToHospitalRegistrationEntry(


Uninitialized attribute: Attribute ownership_type is declared in class ToHospitalRegistrationEntry to have type str but is never initialized.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-17T19:48:17Z

registrations/domain/dto.py

 from registrations.domain.location.location import Address
+from registrations.utils import enum_utils
+from registrations.utils.errors import InvalidRegistrationEntryError


 class RegisterKeyContact(


Unexpected keyword: Unexpected keyword argument extra to call object.__init_subclass__.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-17T19:48:19Z

registrations/domain/hospital/registration.py

@@ -65,7 +54,12 @@ def _validate_number(cls, phone_number: str) -> str:


 # Value Object
-class ContactPerson(pydantic.BaseModel, allow_mutation=False, validate_assignment=True):
+class ContactPerson(


Unexpected keyword: Unexpected keyword argument extra to call object.__init_subclass__.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-17T19:48:20Z

registrations/domain/hospital/registration.py


+    @pydantic.root_validator


Invalid decoration: While applying decorator pydantic.root_validator

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

sonatype-lift · 2022-07-17T19:48:21Z

registrations/domain/location/location.py

@@ -12,7 +12,7 @@ class Address(pydantic.BaseModel, extra=pydantic.Extra.forbid):

    @pydantic.root_validator(pre=True)


Invalid decoration: While applying decorator pydantic.root_validator(...)

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignore

I've recorded this as ignored for this pull request. If you change your mind, just comment @sonatype-lift unignore.

Co-authored-by: Sourcery AI <>

…d to pylintrc extension-pkg-allow-list. added mypy types-pytest-lazy-fixture

zabuldon

Looks good for me.

tests/test_registrations.py

…ors and fails

zabuldon

Looks good.

codecakes added 4 commits July 11, 2022 21:13

fixed module not found error in Dockerfile. updated Readme and remove…

e1c46b3

…d unnecessary code in init. Upgraded pylint version. generated new pylintrc

upgraded versions

45622e0

use COPY

c966d10

refactored application services and added to DTO validations. updated…

1422abb

… pylint rules

sonatype-lift bot reviewed Jul 12, 2022

View reviewed changes

codecakes self-assigned this Jul 13, 2022

codecakes added the enhancement New feature or request label Jul 13, 2022

codecakes and others added 3 commits July 13, 2022 17:03

Merge branch 'develop' into feature/refactor-dto

190c8c2

refactored DTO name. Refactored DTO output. build_hospital_factory is…

d94a918

… responsibility of HospitalRegistrationApplicationService calling domain service

optimize and clean imports

64ce0c5

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

codecakes added 2 commits July 17, 2022 04:01

added errors file. added mypy rules from wolt in toml

7ebc04f

updated pylint and mypy complient code

3de991a

sourcery-ai bot mentioned this pull request Jul 17, 2022

Feature/refactor dto (Sourcery refactored) #19

Merged

sonatype-lift bot reviewed Jul 17, 2022

View reviewed changes

'Refactored by Sourcery' (#19)

78e21fc

Co-authored-by: Sourcery AI <>

codecakes marked this pull request as ready for review July 17, 2022 19:54

codecakes requested review from anjayluh, atuljain, Matt-Murungi and a team July 17, 2022 20:04

codecakes added help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Jul 17, 2022

codecakes added 3 commits July 18, 2022 02:45

added registration hospital application service tests. all pass. Adde…

47b8225

…d to pylintrc extension-pkg-allow-list. added mypy types-pytest-lazy-fixture

added support to optimize import hook

7a950ae

updated linter and dev dependencies for later use

c0e1845

zabuldon reviewed Jul 18, 2022

View reviewed changes

tests/test_registrations.py Outdated Show resolved Hide resolved

codecakes linked an issue Jul 18, 2022 that may be closed by this pull request

Domain Model Design #13

Closed

add support for caplog driven stderr instead of print during test err…

d9e3477

…ors and fails

zabuldon approved these changes Jul 18, 2022

View reviewed changes

codecakes merged commit e17232b into develop Jul 18, 2022

codecakes deleted the feature/refactor-dto branch July 18, 2022 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/refactor dto #16

Feature/refactor dto #16

codecakes commented Jul 12, 2022

sourcery-ai bot commented Jul 12, 2022 •

edited

Loading

sonatype-lift bot Jul 12, 2022

codecakes Jul 13, 2022

sonatype-lift bot Jul 13, 2022

sonatype-lift bot Jul 14, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 14, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 14, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 14, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 14, 2022

sonatype-lift bot Jul 14, 2022

sonatype-lift bot Jul 17, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 17, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

sonatype-lift bot Jul 17, 2022

codecakes Jul 17, 2022

sonatype-lift bot Jul 17, 2022

zabuldon left a comment

zabuldon left a comment

		@@ -12,7 +12,7 @@ class Address(pydantic.BaseModel, extra=pydantic.Extra.forbid):

		@pydantic.root_validator(pre=True)

Feature/refactor dto #16

Feature/refactor dto #16

Conversation

codecakes commented Jul 12, 2022

sourcery-ai bot commented Jul 12, 2022 • edited Loading

Sourcery Code Quality Report

Legend and Explanation

sonatype-lift bot Jul 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 13, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Jul 17, 2022

Choose a reason for hiding this comment

zabuldon left a comment

Choose a reason for hiding this comment

zabuldon left a comment

Choose a reason for hiding this comment

sourcery-ai bot commented Jul 12, 2022 •

edited

Loading