Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove use of tev & fix type errors #365

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

chemwolf6922
Copy link
Contributor

@chemwolf6922 chemwolf6922 commented Dec 22, 2024

Why is this change made

The mips module uses tev as the event loop. Since asyncio is already widely used in this project, it would be better to change the event loop to asyncio to align the stack.

Changes

  • Remove mips's dependency on tev
  • Change IPC method to asyncio's call_soon_threadsafe
  • Fix type errors
  • Refactor some spaghetti code

Tests

  • Tested with my local setup (cloud connection). Initialization and device state update works normally.
  • Please help test in more complex scenarios.

@chemwolf6922 chemwolf6922 marked this pull request as ready for review December 31, 2024 11:44
@chemwolf6922 chemwolf6922 changed the title misc: remove use of tev & fix type errors refactor: remove use of tev & fix type errors Dec 31, 2024
@topsworld topsworld added the enhancement New feature or request label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants