Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWRoute RouteHelper fails to find the INT tile entry node from a BITSLICE_CONTROL site pin #558

Closed
clavin-xlnx opened this issue Oct 12, 2022 · 0 comments · Fixed by #1081
Labels

Comments

@clavin-xlnx
Copy link
Member

clavin-xlnx commented Oct 12, 2022

The method RouteHelper.projectOutputPinToINTNode() has not been tested in RWRoute for BITSLICE_CONTROL site pins and does not find the INT tile entry node for the beginning of a route. For example, the site pin TX_T_OUT when queried, the method returns null when it should return the node INT_INTF_L_CMT_X182Y90/LOGIC_OUTS_R19. In Vivado, we can see that the INT entry node (shown in green) does exist:

image

The method needs to account for the pip connection between the two nodes as shown in blue.

EDIT: For future contributors who will work on this -- a test demonstrating this failure is at #559

clavin-xlnx added a commit that referenced this issue Oct 12, 2022
Signed-off-by: Chris Lavin <[email protected]>
eddieh-xlnx pushed a commit that referenced this issue Jan 12, 2024
Signed-off-by: Chris Lavin <[email protected]>
eddieh-xlnx added a commit that referenced this issue Jan 12, 2024
* Test for #558

Signed-off-by: Chris Lavin <[email protected]>

* Adding comment header

Signed-off-by: Chris Lavin <[email protected]>

* Convert to known failing test

Signed-off-by: Eddie Hung <[email protected]>

---------

Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Co-authored-by: Eddie Hung <[email protected]>
eddieh-xlnx added a commit that referenced this issue Oct 10, 2024
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx added a commit that referenced this issue Oct 10, 2024
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx added a commit that referenced this issue Oct 10, 2024
…1081)

* [RouterHelper] projectOutputPinToINTNode() to breadth-first-search

Much like projectInputPinToINTNode() as this seems necessary for Versal I/Os

Signed-off-by: Eddie Hung <[email protected]>

* Missing import

Signed-off-by: Eddie Hung <[email protected]>

* Fix returned node

Signed-off-by: Eddie Hung <[email protected]>

* Fix projectInputPinToINTNode

Signed-off-by: Eddie Hung <[email protected]>

* Update src/com/xilinx/rapidwright/rwroute/RouterHelper.java

Signed-off-by: eddieh-xlnx <[email protected]>

* Inadvertently fixes #558

Signed-off-by: Eddie Hung <[email protected]>

* projectOutputPinToINTNode() to skip nodes in clocking tiles

Signed-off-by: Eddie Hung <[email protected]>

* Reduce project{Input,Output}PinToINTNode() watchdog to 20

Signed-off-by: Eddie Hung <[email protected]>

* Rework projectInputPinToINTNode(), ignore clocking nodes too

Signed-off-by: Eddie Hung <[email protected]>

---------

Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: eddieh-xlnx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants