[Interchange] Refactor & speedup reader/writers #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Conflicts: src/com/xilinx/rapidwright/interchange/PhysNetlistReader.java
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]> Conflicts: src/com/xilinx/rapidwright/edif/EDIFCell.java src/com/xilinx/rapidwright/edif/EDIFCellInst.java src/com/xilinx/rapidwright/edif/EDIFPort.java
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
commented
May 20, 2023
eddieh-xlnx
force-pushed
the
interchange_enum
branch
2 times, most recently
from
2503baa to
51ca0a9
Compare
eddieh-xlnx
changed the title
eddieh-xlnx
commented
May 23, 2023
Signed-off-by: eddieh-xlnx <[email protected]>
clavin-xlnx
approved these changes
May 30, 2023
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
haydenc-amd
pushed a commit
to haydenc-amd/RapidWright
that referenced
this pull request
Jun 16, 2023
* Refactor Interchange Log/Phys Reader/Writer Signed-off-by: Eddie Hung <[email protected]> * More tidying up Signed-off-by: Eddie Hung <[email protected]> * Fix broken test Signed-off-by: Eddie Hung <[email protected]> * More refactoring/improvements Signed-off-by: Eddie Hung <[email protected]> * Fix collapse macro collision, plus optimize Signed-off-by: Eddie Hung <[email protected]> * Test for collapseMacroUnisims() does not collide Signed-off-by: Eddie Hung <[email protected]> * EDIFNetlist.getHDIPrimitive() to deep copy too Signed-off-by: Eddie Hung <[email protected]> * Split Enumerator into {Identity,String}Enumerator Signed-off-by: Eddie Hung <[email protected]> * Get rid of EDIFEnumerable Signed-off-by: Eddie Hung <[email protected]> Conflicts: src/com/xilinx/rapidwright/edif/EDIFCell.java src/com/xilinx/rapidwright/edif/EDIFCellInst.java src/com/xilinx/rapidwright/edif/EDIFPort.java * Interchange.benchmark() to return Path Signed-off-by: Eddie Hung <[email protected]> * Bump copyright year Signed-off-by: Eddie Hung <[email protected]> * Fix EDIFNetlist.getHDIPrimitive() Signed-off-by: Eddie Hung <[email protected]> * Fix EDIFNetlist.getHDIPrimitive() Signed-off-by: Eddie Hung <[email protected]> * Another EDIFNetlist.getHDIPrimitive() fix Signed-off-by: Eddie Hung <[email protected]> * Update src/com/xilinx/rapidwright/interchange/IdentityEnumerator.java Signed-off-by: eddieh-xlnx <[email protected]> * Address some review comments Signed-off-by: Eddie Hung <[email protected]> * Address some more review Signed-off-by: Eddie Hung <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: eddieh-xlnx <[email protected]> Signed-off-by: Hayden Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
BELPinCachefor fasterBELPinlookups fromSiteInstand string indicesPIPCachefor fasterPIPlookups fromTileand string indicesNumber of optimizations/refactoring/options for higher performance, e.g. deferring
EDIFPortInstListsorting until after all port insts have been inserted.