Add test for Design.movePinsToNewNetDeleteOldNet() #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
clavin-xlnx
added a commit
that referenced
this pull request
Sep 14, 2023
* rc1 Signed-off-by: Chris Lavin <[email protected]> * Test BEL.isSliceFFClkMod() Signed-off-by: Eddie Hung <[email protected]> * PhysNetlistWriter.writePlacement() more careful looking for multi cells Signed-off-by: Eddie Hung <[email protected]> * DesignTools.createCeClkOfRoutethruFFToVCC() to use Cell.isFFRoutethruCell() Signed-off-by: Eddie Hung <[email protected]> * Add TestCell.testFFRoutethruCell() Signed-off-by: Eddie Hung <[email protected]> * Fix test Signed-off-by: Eddie Hung <[email protected]> * Remove Signed-off-by: Eddie Hung <[email protected]> * Add test for Design.movePinsToNewNetDeleteOldNet() (#796) * Add TestDesign.testMovePinsToNewNetDeleteOldNet{,IntraSiteOnly()} Signed-off-by: Eddie Hung <[email protected]> * Remove sitewire merge from DesignTools.makePhysNetNameConsistent() Signed-off-by: Eddie Hung <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: Chris Lavin <[email protected]> Co-authored-by: Chris Lavin <[email protected]> * Test Cell.getAllCorrespondingSitePinNames() works for multi-outputs (#792) * Test Cell.getAllCorrespondingSitePinNames() works for multi-outputs Signed-off-by: Eddie Hung <[email protected]> * Apply suggestions from code review Signed-off-by: eddieh-xlnx <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: eddieh-xlnx <[email protected]> Co-authored-by: Chris Lavin <[email protected]> * rc2 Signed-off-by: Chris Lavin <[email protected]> * rc3 Signed-off-by: Chris Lavin <[email protected]> * rc4 Signed-off-by: Chris Lavin <[email protected]> * 2023.1.3 release jar Signed-off-by: Chris Lavin <[email protected]> --------- Signed-off-by: Chris Lavin <[email protected]> Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: eddieh-xlnx <[email protected]> Co-authored-by: Eddie Hung <[email protected]>
eddieh-xlnx
added a commit
that referenced
this pull request
Sep 14, 2023
* rc1 Signed-off-by: Chris Lavin <[email protected]> * Test BEL.isSliceFFClkMod() Signed-off-by: Eddie Hung <[email protected]> * PhysNetlistWriter.writePlacement() more careful looking for multi cells Signed-off-by: Eddie Hung <[email protected]> * DesignTools.createCeClkOfRoutethruFFToVCC() to use Cell.isFFRoutethruCell() Signed-off-by: Eddie Hung <[email protected]> * Add TestCell.testFFRoutethruCell() Signed-off-by: Eddie Hung <[email protected]> * Fix test Signed-off-by: Eddie Hung <[email protected]> * Remove Signed-off-by: Eddie Hung <[email protected]> * Add test for Design.movePinsToNewNetDeleteOldNet() (#796) * Add TestDesign.testMovePinsToNewNetDeleteOldNet{,IntraSiteOnly()} Signed-off-by: Eddie Hung <[email protected]> * Remove sitewire merge from DesignTools.makePhysNetNameConsistent() Signed-off-by: Eddie Hung <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: Chris Lavin <[email protected]> Co-authored-by: Chris Lavin <[email protected]> * Test Cell.getAllCorrespondingSitePinNames() works for multi-outputs (#792) * Test Cell.getAllCorrespondingSitePinNames() works for multi-outputs Signed-off-by: Eddie Hung <[email protected]> * Apply suggestions from code review Signed-off-by: eddieh-xlnx <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: eddieh-xlnx <[email protected]> Co-authored-by: Chris Lavin <[email protected]> * rc2 Signed-off-by: Chris Lavin <[email protected]> * Add TestPhysNetlistReader.testFFRoutethruCell() Signed-off-by: Eddie Hung <[email protected]> * [PhysNetlistReader] Create FFRoutethruCell-s correctly Signed-off-by: Eddie Hung <[email protected]> * Set siteInst Signed-off-by: Eddie Hung <[email protected]> * Enhance test Signed-off-by: Eddie Hung <[email protected]> --------- Signed-off-by: Chris Lavin <[email protected]> Signed-off-by: Eddie Hung <[email protected]> Signed-off-by: eddieh-xlnx <[email protected]> Co-authored-by: Chris Lavin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including one which has no pins (but does have intra-site routing).
Also eliminate redundant sitewire operations in
DesignTools.makePhysNetNamesConsistent().