Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PhysNetlistWriter] Set PhysPIP.setForward() even if not bidir #819

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[PhysNetlistWriter] Set PhysPIP.setForward() even if not bidir #819

merged 2 commits into from
Sep 14, 2023

Conversation

eddieh-xlnx
Copy link
Collaborator

@eddieh-xlnx eddieh-xlnx commented Sep 14, 2023 •
edited
Loading

Since PhysNetlistReader always consumes it, even if not bidir:

RapidWright/src/com/xilinx/rapidwright/interchange/PhysNetlistReader.java

Lines 564 to 566 in 7cec512

PIP pip = getPIP(tile, pReader.getWire0(), pReader.getWire1());
pip.setIsPIPFixed(pReader.getIsFixed());
pip.setIsReversed(!pReader.getForward());

@eddieh-xlnx eddieh-xlnx changed the title [PhysNetlistWriter] Set PhysPip.setForward() even if not bidir [PhysNetlistWriter] Set PhysPIP.setForward() even if not bidir Sep 14, 2023
@eddieh-xlnx eddieh-xlnx merged commit 2139f60 into master Sep 14, 2023
@eddieh-xlnx eddieh-xlnx deleted the physnetwriter_pip_forward branch September 14, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clavin-xlnx clavin-xlnx clavin-xlnx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddieh-xlnx @clavin-xlnx