Larger Debug Buffer Support #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 9, 2024 16:10
Signed-off-by: Ishita Ghosh <[email protected]>
…ng of the data to match new layout of debug buffer on device Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
AShivangi
approved these changes
Jun 11, 2024
Comment on lines
-20
to
-27
| static constexpr uint32_t size_4K = 0x1000; | ||
| static constexpr uint32_t offset_3K = 0x0C00; | ||
| /* Each record timer entry has 32bit ID and 32bit AIE Timer low value. | ||
| * The first 32 bit in the buffer is used to store total number | ||
| * of record timer entries written so far. So, max_count_in_size_3K is 1 less | ||
| * than total number of entries possible in 3K buffer section. | ||
| */ | ||
| static constexpr uint32_t max_count_in_size_3K = (offset_3K / (2 * sizeof(uint32_t))) - 1; |
There was a problem hiding this comment.
Thanks for removing this!
…e methods Signed-off-by: Ishita Ghosh <[email protected]>
jvillarre
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Enable use of larger debug buffer in ML Timeline, AIE Profile and AIE Debug on Client devices.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Due to limited buffer size on device, we could only get few hundred timestamps for ML Timeline feature which is far short of requirement for most ML designs.
With help of support in driver and ert, we can now sync from device to host when device buffer is full. This facilitates larger debug buffer sufficient to hold data from ML designs.
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Unit and large models on device
Documentation impact (if any)