[VITIS-14334] Review and cleanup GOPS, EGOPS, FPS, Latency in aie-partitions report #8713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diukirde
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
|
Can one of the admins verify this patch? |
rchane
approved these changes
Jan 23, 2025
AShivangi
approved these changes
Jan 24, 2025
stsoe
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Solves https://jira.xilinx.com/browse/VITIS-14334 to show appropriate value for GOPS, EGOPS, FPS, and Latency in aie-partition report.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Currently if GOPS, EGOPS, FPS, and Latency are not configured, the air-partition report shows 0, which may confuse users.
How problem was solved, alternative solutions (if any) and why they were rejected
QOS values will show up as N/A if not configured.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
tested on windows
output of
xrt-smi examine -r aie-partitions
Documentation impact (if any)