xrt-smi rearchitecture Patch 4 #8714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Tondak <[email protected]>
aktondak
requested review from
stsoe,
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
|
Can one of the admins verify this patch? |
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
AShivangi
approved these changes
Jan 24, 2025
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
stsoe
requested changes
Jan 25, 2025
src/runtime_src/core/common/smi.cpp
Outdated
Comment on lines
4
to
10
| #include <boost/property_tree/ptree.hpp> | ||
| #include <boost/property_tree/json_parser.hpp> | ||
| #include <vector> | ||
| #include <tuple> | ||
| #include <string> | ||
| #include <boost/property_tree/ptree.hpp> | ||
| #include <boost/property_tree/json_parser.hpp> |
There was a problem hiding this comment.
Sort in groups. Keep smi.h first, then boost includes and finally system headers
| value_type(value_type), | ||
| description_array(description_array) {} | ||
|
|
||
| ptree to_ptree() const { |
There was a problem hiding this comment.
Like it or not. The convention I prefer to keep under core/common is
return-type
function() [const]
{
}
src/runtime_src/core/common/smi.h
Outdated
| // Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved. | ||
|
|
||
| #pragma once | ||
| #define XRT_CORE_COMMON_SOURCE |
Signed-off-by: Akshay Tondak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR does the following :
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Problem was discovered when we wanted to scale to multiple different tests separately in each shim.
https://jira.xilinx.com/browse/CR-1226870
How problem was solved, alternative solutions (if any) and why they were rejected
Solved through addition of a new field.
Risks (if any) associated the changes in the commit
xrt-smi should be tested for alveo devices.
What has been tested and how, request additional testing if necessary
Tested with MCDM and XDNA drivers.
Documentation impact (if any)
None