Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split npu package into base and npu deployment and development #8723

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

stsoe
Copy link
Collaborator

@stsoe stsoe commented Jan 28, 2025

Problem solved by the commit

The XRT npu component is split into base and npu with latter containing only profiling (xdp) compiled specifically for NPU.
The changes in this PR are mostly in handling package dependencies with CPack.

How problem was solved, alternative solutions (if any) and why they were rejected

The packages are split in deployment and development.

  • xrt_202510.2.19.0_22.04-amd64-base.deb generated.
  • xrt_202510.2.19.0_22.04-amd64-base-dev.deb generated.
  • xrt_202510.2.19.0_22.04-amd64-npu.deb generated.

and corresponding RPMs.

There should be no content in npu-dev package. The PR adjusts xdp_core to be marked as NAMELINK_SKIP. We have base, base-dev, and npu. xdna will depend on base, application developers will install base-dev, profilers will install npu.

Risks (if any) associated the changes in the commit

Risk is that installing xrt-npu now requires first install xrt-base. Without a package repo, this is cumbersome.

stsoe added 2 commits January 28, 2025 13:54
The XRT npu component is split into base and npu with latter
containing only profiling (xdp) compiled specifically for NPU.

The packages are split in deployment and development.
- xrt_202510.2.19.0_22.04-amd64-base.deb generated.
- xrt_202510.2.19.0_22.04-amd64-base-dev.deb generated.
- xrt_202510.2.19.0_22.04-amd64-npu.deb generated.
- xrt_202510.2.19.0_22.04-amd64-npu-dev.deb generated.

The changes in this PR are mostly in handling package dependencies
with CPack.

This commit is specifically for Debian packaging.

Signed-off-by: Soren Soe <[email protected]>
The packages are split in deployment and development.
- xrt_202510.2.19.0_41-x86_64-base.rpm generated.
- xrt_202510.2.19.0_41-x86_64-base-devel.rpm generated.
- xrt_202510.2.19.0_41-x86_64-npu.rpm generated.
- xrt_202510.2.19.0_41-x86_64-npu-devel.rpm generated.

The changes in this PR are mostly in handling package dependencies
with CPack.

This commit is specifically for RPM packaging.

Signed-off-by: Soren Soe <[email protected]>
@stsoe stsoe requested a review from rozumx as a code owner January 28, 2025 22:02
stsoe added 2 commits January 28, 2025 15:26
The xdp_core is not an application library so shouldn't have a namelink.
Additionally, make sure xrt.pc is released with base-dev component.

These change makes npu-dev component empty and the package is not created.

Signed-off-by: Soren Soe <[email protected]>
@stsoe stsoe requested a review from jvillarre as a code owner January 29, 2025 16:15
@stsoe stsoe requested review from maxzhen and removed request for rozumx January 29, 2025 18:40
@stsoe stsoe merged commit 03d2e25 into Xilinx:master Jan 30, 2025
20 checks passed
@stsoe stsoe deleted the npu_split_base branch January 30, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants