Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers: add tracerConfig support and implement contractTracer #683

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

JukLee0ira
Copy link

@JukLee0ira JukLee0ira commented Oct 21, 2024

Proposed changes

  1. Add TracerConfig to Existing Tracer:

    • Added a TracerConfig option, primarily for onlyTopCall, to provide more control over which calls are traced.
  2. Implement ContractTracer:

    • Introduced a new ContractTracer to locate created contracts and return their addresses.
    • Added configuration options to retrieve the corresponding contract bytecode when needed.

Example

Request

RPC="http://172.16.3.16:8547"
NUMBER="0x399e"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 1002,
  "method": "debug_traceBlockByNumber",
  "params": [
    "'"${NUMBER}"'", {
        "tracer":"contractTracer"
    }
  ]
}' | jq

Response

{
  "jsonrpc": "2.0",
  "id": 1002,
  "result": [
    {
      "result": [
        "0xf63f8ba05d790b93db0005de3e65d90cd0b68bf6"
      ]
    }
  ]
}

Request

RPC="http://172.16.3.16:8547"
NUMBER="0x3a9e"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 1002,
  "method": "debug_traceBlockByNumber",
  "params": [
    "'"${NUMBER}"'", {
        "tracer":"contractTracer","tracerConfig": {"opCode": "PREVRANDAO"}
    }
  ]
}' | jq

Response

{
  "jsonrpc": "2.0",
  "id": 1002,
  "result": [
    {
      "result": [
        "0xf63f8ba05d790b93db0005de3e65d90cd0b68bf6"
      ]
    }
  ]
}

Request

RPC="http://172.16.3.16:8547"
NUMBER="0x399e"
curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 1002,
  "method": "debug_traceBlockByNumber",
  "params": [
    "'"${NUMBER}"'", {
        "tracer":"contractTracer","tracerConfig": {"opCode": "PRO"}
    }
  ]
}' | jq

Response

{
  "jsonrpc": "2.0",
  "id": 1002,
  "result": [
    {
      "error": "opcode PRO not defined"
    }
  ]
}

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

eth/tracers/native/contract.go Outdated Show resolved Hide resolved
eth/tracers/native/contract.go Outdated Show resolved Hide resolved
eth/tracers/native/contract.go Outdated Show resolved Hide resolved

func (t *contractTracer) CaptureStart(env *vm.EVM, from common.Address, to common.Address, create bool, input []byte, gas uint64, value *big.Int) {
if create || t.config.OpCode == "CALL" {
storeOpCode(t, env, to, input)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what this is for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only need to return the code without specifying an opcode, we should record the contract address here.

To find the CALL opcode, we should search within CaptureState. The CALL opcode here isn’t part of the contract’s internal opcodes. I was confused about this but have now corrected it.

@JukLee0ira JukLee0ira force-pushed the traceBlockByNumber branch 3 times, most recently from 81a7f0c to cd73ea7 Compare October 25, 2024 11:19
Copy link

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job on this!

@JukLee0ira JukLee0ira force-pushed the traceBlockByNumber branch 3 times, most recently from 3d01f43 to 35a2f98 Compare November 6, 2024 06:55
@s1na
Copy link

s1na commented Jan 21, 2025

Please merge this. It has been sitting in a ready-state for a long time now.

@gzliudan
Copy link
Collaborator

Please merge this. It has been sitting in a ready-state for a long time now.

Let me review this PR

@gzliudan
Copy link
Collaborator

@JukLee0ira Please modify the subject of last 2 commits.

@JukLee0ira JukLee0ira force-pushed the traceBlockByNumber branch 2 times, most recently from c49085c to 3001c51 Compare January 22, 2025 04:35
@JukLee0ira JukLee0ira changed the title Add TracerConfig Support and Implement Contract Tracer eth/tracers: add tracerConfig support and implement contractTracer Jan 22, 2025
@gzliudan gzliudan merged commit 4e18b25 into XinFinOrg:dev-upgrade Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants