Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rusqlite to JSON. #158

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Rusqlite to JSON. #158

merged 4 commits into from
Jun 8, 2022

Conversation

Xithrius
Copy link
Owner

@Xithrius Xithrius commented Jun 3, 2022 •
edited
Loading

Closes #157

Database operations are not needed. JSON shall be migrated to due to its simple format, so a user can modify it in the text file, if they'd like.

Warning - config now uses [storage] section instead of a [database] section. To work around this, you can replace the [database] section with this:

[storage]
# If previous channels switched to should be tracked.
channels = false
# If previous username mentions should be tracked.
mentions = false

@Xithrius Xithrius added type: enhancement New feature or request area: dependencies Updating a dependency file area: backend Internal enhancements labels Jun 3, 2022
@pull-request-size pull-request-size bot added size/L and removed size/XS labels Jun 8, 2022
@Xithrius Xithrius marked this pull request as ready for review June 8, 2022 01:59
@Xithrius Xithrius requested a review from kosayoda June 8, 2022 01:59
Den4200
Den4200 approved these changes Jun 8, 2022
View reviewed changes
Copy link

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto, looks good to me!

@Xithrius
Copy link
Owner Author

Xithrius commented Jun 8, 2022

Thank

@Xithrius Xithrius merged commit dc41fa2 into main Jun 8, 2022
@Xithrius Xithrius deleted the rusqlite-to-json branch June 8, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4200 Den4200 Den4200 approved these changes

@kosayoda kosayoda Awaiting requested review from kosayoda

Assignees
No one assigned
Labels
area: backend Internal enhancements area: dependencies Updating a dependency file size/L type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace rusqlite with JSON.
2 participants
@Xithrius @Den4200