Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Windows winapi crash on run with SetUnderlineColor #651

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

Xithrius
Copy link
Owner

Closes #648

@Xithrius Xithrius force-pushed the winapi-underline-fix branch from e1c7797 to 9ea0257 Compare August 18, 2024 17:03
@pull-request-size pull-request-size bot added size/L and removed size/S labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 23.22%. Comparing base (e9e3508) to head (f674e1c).
Report is 2 commits behind head on main.

Files Patch % Lines
src/ui/components/emote_picker.rs 0.00% 9 Missing ⚠️
src/utils/styles.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   23.10%   23.22%   +0.11%     
==========================================
  Files          42       42              
  Lines        5492     5400      -92     
==========================================
- Hits         1269     1254      -15     
+ Misses       4223     4146      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xithrius Xithrius marked this pull request as ready for review August 19, 2024 05:07
@Xithrius Xithrius merged commit 92dc384 into main Aug 19, 2024
8 checks passed
@Xithrius Xithrius deleted the winapi-underline-fix branch August 19, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem on console without support of color
1 participant