Skip to content

Commit

Permalink
disable YUV444P for now (no idea what is wrong with it - docs are abs…
Browse files Browse the repository at this point in the history
…olutely useless)

git-svn-id: https://xpra.org/svn/Xpra/trunk@4731 3bb7dfac-3a0b-4e04-842a-767bc560f471
totaam committed Nov 10, 2013
1 parent af9af07 commit e03619a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/xpra/codecs/nvenc/encoder.pyx
Original file line number Diff line number Diff line change
@@ -1407,12 +1407,14 @@ cdef class Encoder:
d = self.cuda_device
da = driver.device_attribute
try:
if self.quality<50:
if True:
self.kernel_name, self.kernel = get_BGRA2NV12(self.device_id)
self.bufferFmt = NV_ENC_BUFFER_FORMAT_NV12_PL
self.pixel_format = "NV12"
cuda_height = self.encoder_height*3/2
else:
#FIXME: YUV444P doesn't work and I don't know why
#No idea what "separateColourPlaneFlag" is meant to do either
self.kernel_name, self.kernel = get_BGRA2YUV444P(self.device_id)
self.bufferFmt = NV_ENC_BUFFER_FORMAT_YUV444_PL
self.pixel_format = "YUV444P"
@@ -1478,6 +1480,8 @@ cdef class Encoder:
if presetConfig!=NULL:
presetConfig.presetCfg.encodeCodecConfig.h264Config.enableVFR = 1
presetConfig.presetCfg.encodeCodecConfig.h264Config.idrPeriod = NVENC_INFINITE_GOPLENGTH
#needed for YUV444P?
#presetConfig.presetCfg.encodeCodecConfig.h264Config.separateColourPlaneFlag = 1
params.encodeConfig = &presetConfig.presetCfg
else:
self.preset_name = None

0 comments on commit e03619a

Please sign in to comment.