Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click ends up on the screen edge #2697

Closed
totaam opened this issue Apr 1, 2020 · 21 comments
Closed

Right click ends up on the screen edge #2697

totaam opened this issue Apr 1, 2020 · 21 comments
Labels
bug Something isn't working client geometry
Milestone

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 1, 2020

Issue migrated from trac ticket # 2697

component: client | priority: major

2020-04-01 14:25:04: stdedos created the issue


In some cases (I assume custom right-click menus) I see this for windows on my WQHD monitor:

[[Image(xpra_right-click_ends-up-on-the-screen-edge.png)]]

Unfortunately, I don't have more info data than these:

"Xpra-Python3-x86_64_4.0-[r25894](../commit/19b846eb99133c0526c58dc6390a01873d52acdf)\xpra_cmd" attach ssh://user@ip/20 --ssh="plink -ssh -agent" --modal-windows=no --title="@title@ on @hostname@/@server-display@" --opengl=no

2020-04-01 16:20:57,638 Xpra GTK3 client version 4.0-[r25894](../commit/19b846eb99133c0526c58dc6390a01873d52acdf) 64-bit
2020-04-01 16:20:57,640  running on Microsoft Windows 10
2020-04-01 16:20:57,713 Warning: failed to import opencv:
2020-04-01 16:20:57,714  No module named 'cv2'
2020-04-01 16:20:57,714  webcam forwarding is disabled
2020-04-01 16:20:58,418 GStreamer version 1.16.2 for Python 3.8.2 64-bit
2020-04-01 16:20:58,696 keyboard layout code 0x409
2020-04-01 16:20:58,697 identified as 'United States - English' : us
2020-04-01 16:20:59,053  keyboard settings: layout=us
2020-04-01 16:20:59,056  desktop size is 4160x1440 with 1 screen:
2020-04-01 16:20:59,056   Default (1100x381 mm - DPI: 96x96) workarea: 4160x1400
2020-04-01 16:20:59,056     Generic PnP Monitor 1600x900 (309x174 mm - DPI: 131x131) workarea: 1600x860
2020-04-01 16:20:59,056     C32JG5x 2560x1440 at 1600x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400

Xenial server $ xpra --version
xpra v3.0.8-25767

Since #2642's spam is toooo damn high

@totaam
Copy link
Collaborator Author

totaam commented Apr 1, 2020

2020-04-01 14:25:19: stdedos uploaded file xpra_right-click_ends-up-on-the-screen-edge.png (83.8 KiB)

xpra_right-click_ends-up-on-the-screen-edge.png

@totaam
Copy link
Collaborator Author

totaam commented Apr 1, 2020

Can you please include the -d geometry log output? (server log, running both server and client with the flag)

@totaam
Copy link
Collaborator Author

totaam commented Apr 2, 2020

2020-04-02 14:52:22: stdedos uploaded file redact-xpra-2697.log (137.1 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Apr 9, 2020

I don't see anything suspicious in there. I can't be certain which window id is the one on the right hand side, but this looks like it could be the one:

initial X11 position and size: requested((3803, 639, 347, 138),
    {'position': (3803, 639), 'gravity': 1, 'minimum-size': (136, 39)})=(3803, 639, 347, 138)

And it looks to me like we're just honouring the position requested by the window using its WM_NORMAL_HINTS.

Can you attach the server's -d window,metadata,x11,geometry log output of just when the problematic window shows up - or at least tell me what time to look for. (because that's going to be quite verbose).

r26055 fixes a minor bug, r26056 improves the debug logging.

@totaam
Copy link
Collaborator Author

totaam commented Apr 17, 2020

2020-04-17 21:58:23: stdedos commented


Replying to [comment:4 Antoine Martin]:

Can you attach the server's -d window,metadata,x11,geometry log output of just when the problematic window shows up - or at least tell me what time to look for. (because that's going to be quite verbose).

I'm sorry, that must have slipped through the cracks.

Is this a client or a server change?
If it's a server one, does it have any dependencies? Because Xenial is stuck on v3 ...

@totaam
Copy link
Collaborator Author

totaam commented Apr 18, 2020

r26055 was wrong anyway and got reverted: #2734.
So only the log.

@totaam
Copy link
Collaborator Author

totaam commented May 8, 2020

2020-05-08 15:39:48: stdedos commented


There you go. This is how it looks like when I right-click:

[[Image(xpra-2697-appears-lower.png)]]

(A second error here: Sublime underneath somehow is getting hover-focus)

@totaam
Copy link
Collaborator Author

totaam commented May 8, 2020

2020-05-08 15:39:58: stdedos uploaded file redact-xpra-2697-appears-lower.log (103.1 KiB)

@totaam
Copy link
Collaborator Author

totaam commented May 8, 2020

2020-05-08 15:40:05: stdedos uploaded file xpra-2697-appears-lower.png (69.1 KiB)

xpra-2697-appears-lower.png

@totaam
Copy link
Collaborator Author

totaam commented May 13, 2020

2020-05-13 14:42:23: stdedos commented


So, for this layout:

[[Image(http://xpra.org/trac/attachment/ticket/2658/xpra-geometry-ApplicationFrameHost_2020-03-20_09-17-15.png)]]

On the right monitor, the image is the same as the description
For the left monitor, the image is the same as the comment above

@totaam
Copy link
Collaborator Author

totaam commented May 19, 2020

2020-05-19 12:37:59: stdedos commented


Maybe (?) related to this:

I click-drag on the text area (to select), and instead my mouse ends up dragging the source file tabs. 😕

[[Image(xpra-2697-pycharm-click-drag.png)]]

@totaam
Copy link
Collaborator Author

totaam commented May 19, 2020

2020-05-19 12:38:18: stdedos uploaded file xpra-2697-pycharm-click-drag.png (5.7 KiB)

xpra-2697-pycharm-click-drag.png

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2020

2020-07-10 13:01:17: stdedos commented


I think we have discussed it somewhere else too, but I cannot remember where

For Server:

$ xrandr
Screen 0: minimum 8 x 8, current 6400 x 1440, maximum 32767 x 32767
DP-0 connected primary 2560x1440+0+0 (normal left inverted right x axis y axis) 597mm x 336mm
   2560x1440     59.95*+
   1920x1200     59.88  
   1920x1080     60.00    59.94    50.00    23.97    60.05    60.00    50.04  
   1680x1050     59.95  
   1600x1200     60.00  
   1280x1024     75.02    60.02  
   1280x800      59.81  
   1280x720      60.00    59.94    50.00  
   1152x864      75.00  
   1024x768      75.03    60.00  
   800x600       75.00    60.32  
   720x576       50.00  
   720x480       59.94  
   640x480       75.00    59.94    59.93  
DP-1 disconnected (normal left inverted right x axis y axis)
DP-2 connected 1920x1080+2560+180 (normal left inverted right x axis y axis) 527mm x 296mm
   1920x1080     60.00*+
   1600x900      60.00  
   1280x1024     75.02    60.02  
   1152x864      75.00  
   1024x768      75.03    60.00  
   800x600       75.00    60.32  
   640x480       75.00    59.94  
DP-3 disconnected (normal left inverted right x axis y axis)
DP-4 connected 1920x1080+4480+180 (normal left inverted right x axis y axis) 527mm x 296mm
   1920x1080     60.00*+
   1600x900      60.00  
   1280x1024     75.02    60.02  
   1152x864      75.00  
   1024x768      75.03    60.00  
   800x600       75.00    60.32  
   640x480       75.00    59.94  
DP-5 disconnected (normal left inverted right x axis y axis)

and

Client (same computer)

$ xpra --version
xpra v3.0.10-26630
$ xrandr
xrandr: Failed to get size of gamma for output screen
Screen 0: minimum 1 x 1, current 6400 x 1440, maximum 7680 x 4320
screen connected 6400x1440+0+0 0mm x 0mm
   7680x4320      0.00  
   5120x1152     27.78  
   6400x1440     17.79* 

"File" Menu ends up in weird places:

[[Image(Screenshot 2020-07-10 14:47:39.png)]]
(left-most monitor)

I have seen that, if the window is in the server's middle monitor, the right-click can very well end-up on the right-most monitor.

-What makes this even weird* is that, as soon as I started writing this (and attempted to try to get a screenshot), it "magically" fixed itself!!!

The above screenshot now looks as it should: File menu glued at the 'File label, Unity Deskbar' intersection.
...

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2020

2020-07-10 13:01:32: stdedos uploaded file Screenshot 2020-07-10 14:47:39.png (132.2 KiB)

Screenshot 2020-07-10 14:47:39.png

@stdedos
Copy link
Collaborator

stdedos commented Apr 30, 2021

Right click ends up on the screen edge > Right click / File menus end up unrelated to their "parent" (mouse click, menu toolbar)

@stdedos
Copy link
Collaborator

stdedos commented Jul 13, 2021

I was about to start a "Jetbrains hover tooltips appear unrelated to mouse cursor" ticket, but it seems that all of the issues presented here (except #2697 (comment), #2697 (comment)) are somewhat related to each other.

"Jetbrains hover tooltips appear unrelated to mouse cursor", for example, on static analysis errors (in this case, from the provided Shellcheck extension).

For the familiar monitor setup, 1336x..⊥2560x.. (merged like so: ⊥), Jetbrains App maximized on the big monitor, a tooltip at the ~20% of monitor's width, ends up fully to the right.
However, if I move the App to left and hover again, the tooltip ends up where it's supposed to.
... and then, if I move the App back to the big monitor, the tooltip (again) ends up where it's supposed to.

Might be some issue with re-attaching? 😕

Might be also related to: #2703

@totaam
Copy link
Collaborator Author

totaam commented Jul 13, 2021

Might be some issue with re-attaching? confused

Might also be an issue with Xvfb / Xdummy, something like #349.
Can you try with a patched Xdummy?

@stdedos
Copy link
Collaborator

stdedos commented Jul 13, 2021

Can you try with a patched Xdummy?

Do you mean this patch? 871e8c7

To make sure I understand, if I use Xvfb, I automatically use Xdummy?

@totaam
Copy link
Collaborator Author

totaam commented Jul 13, 2021

Do you mean this patch? 871e8c7

Yes.

To make sure I understand, if I use Xvfb, I automatically use Xdummy?

No.
You would need to change to use Xdummy by setting the xvfb option in your `/etc/xpra/xpra.conf/ config file.

@totaam
Copy link
Collaborator Author

totaam commented Apr 12, 2022

Client multi-monitor support is much improved in xpra 4.4 thanks to #56 (comment) (this is a pure server-side change - requires dummy version 0.4.0), sadly the per-monitor DPI is still not detected correctly with MS Windows clients: #1526 (comment)

When you get a chance, please re-test with xpra server version ea713e5 or later and XPRA_DUMMY_MONITORS=1.

@totaam
Copy link
Collaborator Author

totaam commented Mar 26, 2023

One year ago, I'm going to assume that xpra 4.4 or later with dummy 0.4.0 or later fixes this issue.

@totaam totaam closed this as completed Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client geometry
Projects
None yet
Development

No branches or pull requests

2 participants