Add a window showing all shortcuts

[totaam]

Issue migrated from trac ticket # 2779

component: client | priority: minor | resolution: fixed

2020-05-27 09:40:50: stdedos created the issue

---

From #2762#comment:20

Ctrl+Shift+F5 does not seem to work 😕
Which ShortcutKey? Cmd / Ctrl?
--shortcut-modifiers=auto should be using Meta+Shift on mswindows.
You can change it, ie: --shortcut-modifiers=Control+Shift.

btw, are all the available shortcuts collected/listed somewhere?

If not, would you add something along those lines:
[[Image(/raw-attachment/ticket/2762/xpra-example-shortcuts.png)]]

(my mockup is not perfect, but I hope it conveys the idea)

You can assign prefix+? to it (the /? key, not necessarily the ? if it is harder to map because of "Shift" weirdness), and a tray-list-entry

[totaam]

Ugly read-only shortcut window added in r27435.

Feel free to create a new ticket for editing (which is much harder to implement).

[totaam]

2020-09-10 09:10:04: stdedos commented

---

Replying to [comment:1 Antoine Martin]:

Ugly read-only shortcut window added in r27435.

I'll wait for a new Win10 zip version to land in order to test it

Feel free to create a new ticket for editing (which is much harder to implement).

No, nonono, it already sounds enough complicated.
I am happy if I can continuously check what are the current shortcuts.
With the exception of Shift+F11 (which conflicts with an existing one of mine), every shortcut seems to be "well-defined" given the abundance of them all over the place.

[totaam]

2020-09-16 09:00:05: stdedos commented

---

Weeeeeell ...

"Xpra-Python3-x86_64_4.1-r27467M\xpra_cmd" attach ssh://user@ip/3 --ssh="plink -ssh -agent" --modal-windows=no --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps

2020-09-16 10:56:46,597 Xpra GTK3 client version 4.1-r27467M 64-bit
2020-09-16 10:56:46,600  running on Microsoft Windows 10
2020-09-16 10:56:49,261 GStreamer version 1.18.0 for Python 3.8.5 64-bit
2020-09-16 10:56:49,609 created named pipe '\\.\pipe\Xpra\4288'
2020-09-16 10:56:49,918 keyboard layout code 0x409
2020-09-16 10:56:49,919 identified as 'United States - English' : us
2020-09-16 10:56:50,312  keyboard settings: layout=us
2020-09-16 10:56:50,325  desktop size is 4160x1440 with 1 screen:
2020-09-16 10:56:50,325   Default (1100x381 mm - DPI: 96x96) workarea: 4160x1400
2020-09-16 10:56:50,325     Generic PnP Monitor 1600x900 at 0x534 (309x174 mm - DPI: 131x131) workarea: 1600x860 at 0x534
2020-09-16 10:56:50,326     C32JG5x 2560x1440 at 1600x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400 at 1600x0
2020-09-16 10:56:54,535 enabled remote logging
2020-09-16 10:56:54,539 Xpra GTK3 X11 server version 3.0.10-26630 64-bit
2020-09-16 10:56:54,540  running on Linux Ubuntu 16.04 xenial
2020-09-16 10:56:54,554 Attached to ip:22
2020-09-16 10:56:54,555  (press Control-C to detach)


(xpra_cmd:4288): Pango-WARNING **: 10:56:55.394: couldn't load font "Bitstream Vera Sans Not-Rotated 14.662109375", falling back to "Sans Not-Rotated 14.662109375", expect ugly output.
2020-09-16 10:56:56,278 sound output using 'opus' audio codec
2020-09-16 10:56:56,432 UI thread is now blocked
2020-09-16 10:56:56,894 UI thread is running again, resuming
Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_tray_menu_base.py", line 645, in show_shortcuts
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_client_base.py", line 549, in show_shortcuts
ModuleNotFoundError: No module named 'xpra.client.gtk3.show_shortcuts'

Also: Weird build ID: r27467M
Also also: Missing signature/md5/sha1 metafiles

[totaam]

ModuleNotFoundError: No module named 'xpra.client.gtk3.show_shortcuts'

I forgot one file, this was fixed this morning: r27469.
I've just pushed a new mswindows build.

Also: Weird build ID: r27467M

That's because of uncommitted changes I am working on - nothing major or noticeable.

Also also: Missing signature/md5/sha1 metafiles

Hmm. Not sure why.

[totaam]

2020-09-16 10:10:41: stdedos commented

---

Replying to [comment:4 Antoine Martin]:

ModuleNotFoundError: No module named 'xpra.client.gtk3.show_shortcuts'
I forgot one file, this was fixed this morning: r27469.
I've just pushed a new mswindows build.

Now works (y)

I guess some other things to do would be some string beautification (s/mod1/Alt/g etc, Title case for shortcuts), and more meaningful action names (magic_key?).
But they are slightly off-scope too.

Also: Weird build ID: r27467M
That's because of uncommitted changes I am working on - nothing major or noticeable.

Also also: Missing signature/md5/sha1 metafiles
Hmm. Not sure why.

I think the M-builds are not signed-by-default

[stdedos]

Is show_shortcuts assigned a shortcut itself by default?

Should it? In the event of #3586, and man-page not including the default shortcuts (not that I am saying it should), "it would've been helpful" to have a way to trigger show_shortcuts from a live instance

If the above is agreeable, then maybe add that keyboard shortcut also:

• to the man-page, and/or
• https://github.com/Xpra-org/xpra/blob/master/docs/FAQ.md, and/or
• the wiki

[totaam]

it would've been helpful" to have a way to trigger show_shortcuts from a live instance

Done, the F6 shortcut will bring up this window and the F7 one will bring up the documentation in a browser window.

You can get to the documentation with xpra docs. (bar small fix above)

(no MS Windows builds yet..)