Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fine grained control channel access #3574

Closed
totaam opened this issue Jul 12, 2022 · 1 comment
Closed

fine grained control channel access #3574

totaam opened this issue Jul 12, 2022 · 1 comment
Labels
enhancement New feature or request network security

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 12, 2022 •
edited
Loading

#3573 provides an on / off toggle for the control channel, this disables printing when the feature is turned off.

It would be better to specify which control commands are (not) allowed and to disable the control channel on a per-socket basis, similar to what was done for the shell: #2750 (comment)
@totaam totaam added enhancement New feature or request network security labels Jul 12, 2022
totaam added a commit that referenced this issue Dec 25, 2023
@totaam
#3574 add 'control' to socket options
972cc90
@totaam
Copy link
Collaborator Author

totaam commented Dec 25, 2023

Done in the commit above, the control attribute is enabled by default for all sockets but it can be disabled for each bind argument.
ie:

xpra start  --bind-tcp=0.0.0.0:10000,control=no

@totaam totaam closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request network security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam