MacOS builds OpenGL backend does not paint the window

[totaam]

Not sure when it broke, perhaps one of the numerous updates in Xpra-org/gtk-osx-build#25.

[totaam]

This may well be related: something (probably GTK) prints Unable to create basic Accelerated OpenGL renderer

[totaam]

Building from the 3.1.x branch results in an app bundle that does paint the window - so this must be a regression.
But none of the 4.x releases paint the window.. and for sure this used to work. How strange!

[totaam]

Started bisecting at dc0e286 with fixes on top:

• call gtk-mac-bundler with python3
• skip sys.version check in setup.py
• /Users/macos/gtk/inst/bin/gtk-query-immodules-2.0 was missing (symlinked from gtk-query-immodules-3.0)
• BUILDARGS="--without-enc_ffmpeg --without-dec_avcodec2 ./make-app.sh to avoid errors due to ffmpeg v6 being installed
• add --without-strict to BUILDARGS when building older versions
• DO_TESTS=0 ./make-app.sh because some tests would fail..
• PYTHON=python3 ./make-app.sh to prevent issues with gtk-mac-bundler not expecting a full path for $PYTHON

Then the builds started failing somewhere in py2app..
Was going to try ca0a121 next.

[totaam]

No longer occurring after a clean full rebuild.
My guess is that this was another side effect of the libffi breakage: Xpra-org/gtk-osx-build#22

[totaam]

FFS, happening again, on two different build systems: 10.14.x and 12.x

Didn't happen with the secondary-clean-user-complete-rebuild on 10.14.x - but that was running the newer, problematic libffi with disabled event listener - or was it just another 3.1.x build...

[totaam]

Same build VM, same version of gtk-osx-build but built and rebuilt at slightly different times: one works with the latest v3.1.x version and one does not. Sigh.

Using the one that does at least occasionally work, bisecting mostly by hand again - assuming that the failure isn't intermittent:

• b3bdff7 4.0.x bad
• a241d7f 3.0 - py2app fails to build with assert g_type != TYPE_NONE
• fa613cf - OK (with Gtkosx_application fix) - no OpenGL
• 2d799ec - segfaults
• c0ed6f0 - segfaults
• 93cd1f8 - OK but no OpenGL
• 7a92ffc - segfaults
• 7a80d8a - OK but no OpenGL
• b20d617 - OK but no OpenGL
• 3b5d7f5 - OK but no OpenGL
• d4b6a07 - OK but no OpenGL
• cb7f94b - OK but no OpenGL
• 7da397b - segfaults

Using a modified version of xpra.platform.darwin.gl_context.py from the v3.1.x branch still segfaults.

Using the xpra/client/gl source from version 3.1.x with a 5.0 client can be done without too many changes, also does not paint!
Then merging xpra/client and xpra/platform/darwin from 3.1.x and now it does paint!

[totaam]

A kinda working branch can be found in 8cc8c83.
Summary: 112 files changed, 9667 insertions(+), 8527 deletions(-)
Not exactly easy to bisect.

[totaam]

I don't really understand what changed in GTK to require a completely different repaint function on MacOS.. but at least this works again.