Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix kernel not dispose when closed #101

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Feb 14, 2022

Description

This will fix the 'zombie' kernel still exist when closing/refreshing tab.

Also, as discussed before, remove the need to create a kernel every time run button clicked. Currently, it'll use the same kernel as long as the output panel still exist.

References

#55

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Try running xircuits multiple times without closing the output panel.
    1. The xircuits shouldn't prompt user to select a kernel after the first run.
    2. It'll only use the kernel created when the first run was clicked.
  2. Try running xircuits and then remove the output panel.
    1. Try run it again and it should prompt user to select a kernel.
  3. While the output panel exist, close/reload the tab.
    1. The xircuits's kernel shouldn't exist in the 'Running Kernels' panel.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Don't manual close the xircuits's kernel in the 'Running Kernels' panel. It'll break the xircuits kernel and refresh is needed to fix it.

@AdrySky AdrySky added the bug Something isn't working label Feb 14, 2022
@AdrySky AdrySky requested a review from MFA-X-AI February 14, 2022 09:15
@AdrySky AdrySky self-assigned this Feb 14, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a fast pull request, thanks!
Can confirm that the tests work in this pull request. I believe this will help users to not have zombie kernels for long running sessions. Great work!

@MFA-X-AI MFA-X-AI merged commit a34bbb8 into master Feb 14, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-kernel-disposed-when-closed branch February 14, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants