🐛Fix kernel not dispose when closed #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will fix the 'zombie' kernel still exist when closing/refreshing tab.
Also, as discussed before, remove the need to create a kernel every time run button clicked. Currently, it'll use the same kernel as long as the output panel still exist.
References
#55
Pull Request Type
Type of Change
Tests
Tested on?
Notes
Don't manual close the xircuits's kernel in the 'Running Kernels' panel. It'll break the xircuits kernel and refresh is needed to fix it.