Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Create optional python compiler code generator #118

Merged
merged 1 commit into from
Mar 4, 2022
Merged

🎨Create optional python compiler code generator #118

merged 1 commit into from
Mar 4, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 3, 2022 •
edited
Loading

Description

This will create an optional code generator for the python compiler. Either default run or debugging.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Make sure xircuits is runnable.
    1.Also, see its python script, does it have like flask etc.? It shouldn't have it.
  2. Run xircuits with debugger and kill it. See its script. It should've all the necessary thing like flask etc.
    1. Also, try run the xircuits using the 'run w/o compile' option to run its script. It should be able to run.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Mar 3, 2022
@AdrySky AdrySky requested a review from MFA-X-AI March 3, 2022 07:03
@AdrySky AdrySky self-assigned this Mar 3, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Windows and Linux WSL,
All functions work properly, great work! This will allow users to see the simple codegen view as intended and modify it if needed.

@MFA-X-AI MFA-X-AI merged commit 6162e2d into master Mar 4, 2022
@MFA-X-AI MFA-X-AI deleted the adry/optional-python-compiler branch March 4, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI