Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Update toolbar button and switch context menu shortcut key #156

Merged
merged 4 commits into from
Apr 28, 2022
Merged

🎨Update toolbar button and switch context menu shortcut key #156

merged 4 commits into from
Apr 28, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Apr 28, 2022 •
edited
Loading

Description

This update and rearrange the toolbar button. Also, switch the shortcut keys between context menu and component panel.

Updated Toolbar

Removed:

  1. Revert

Added:

  1. Undo
  2. Redo
  3. Cut
  4. Copy
  5. Paste

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Test each toolbar button
  2. Right-clicking canvas to open context menu
  3. Ctrl+left-click to open component panel

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Apr 28, 2022
@AdrySky AdrySky requested a review from MFA-X-AI April 28, 2022 02:37
@AdrySky AdrySky self-assigned this Apr 28, 2022
@AdrySky AdrySky requested a review from mansouralawi April 28, 2022 02:38
@AdrySky AdrySky changed the title 🎨Update toolbar button 🎨Update toolbar button and switch context menu shortcut key Apr 28, 2022
MFA-X-AI
MFA-X-AI approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the E2E test with the new tooltip strings, now the E2E check passes.

The new way of opening the context menu feels really natural to use now, love it already.
All toolbar buttons also work well, undo and redo included. Great work!

@MFA-X-AI MFA-X-AI merged commit b7664d5 into master Apr 28, 2022
@MFA-X-AI MFA-X-AI deleted the adry/update-toolbar-button branch April 28, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

@mansouralawi mansouralawi Awaiting requested review from mansouralawi

Assignees

@AdrySky AdrySky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI