Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Fix node position changes #174

Merged
merged 2 commits into from
Jul 25, 2022
Merged

🐛Fix node position changes #174

merged 2 commits into from
Jul 25, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jul 20, 2022 •
edited
Loading

Description

This will fix detecting node's position changes. It's also indirectly fix editing Literal node by double click as just selecting a node won't change the xircuits.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Just selecting node after moving a different node wont detect its changes.
    1. Move a node
    2. Save xircuits
    3. Select a different node
    4. See that xircuits is not in dirty state.
    5. Repeat step 1-4 in a different branch. You will see that the xircuits in dirty state
  2. Try double click any literal to edit it

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Jul 20, 2022
@AdrySky AdrySky requested a review from MFA-X-AI July 20, 2022 03:21
@AdrySky AdrySky self-assigned this Jul 20, 2022
MFA-X-AI
MFA-X-AI approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my win10, editing literals are working perfectly again. Great work!

@MFA-X-AI MFA-X-AI merged commit 479b1bf into master Jul 25, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-node-position-changes branch July 26, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI