Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update Xircuits Config Init #219

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Mar 2, 2023

Description

Small PR that changes (reverts) the way .xircuits/config.ini is initialized. It now copies over the config from the site-packages when you install xircuits. This way it should always have the matching config as opposed to currently how it fetches the most latest and greatest.

References

d0a9231

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Grab the wheel from the python wheel builder. Install it in a clean directory.
  2. Start xircuits normally. Verify that the .xircuits/config.ini is now present in the current working directory.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

As with the previous attempt #66 (comment), we were unable to graft the .xircuits directory in the venv directory. As a result, the .xircuits/config.ini is copied from xai_components/.xircuits/config.ini which is a duplicate of the one in the base directory. Let me know if anyone has a better way of approaching this.

Copy link
Member

@mansouralawi mansouralawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it works fine

@mansouralawi mansouralawi merged commit 69c3b13 into master Mar 7, 2023
@mansouralawi mansouralawi deleted the fahreza/update-cmds branch March 7, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants