Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stop event propagating between different active widgets #254

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Jun 1, 2023

Description

This patch addresses an issue of event propagation between different active widgets (such as an input dialogue panel or the tray widget) in the Xircuits application. Previously, keyboard shortcuts (ctrl+z, ctrl+y, ctrl+s, ctrl+x, ctrl+c, ctrl+v, Delete, and Backspace) were executed regardless of the active widget, which resulted in unintended consequences.

The change ensures that the shortcuts are only executed when the event's target is within the currently active widget. This is achieved by adding a condition to check if the target of the event is contained within the active widget before executing any commands.

References

#253

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Copy a node. Then open an active panel (such as the tray widget or a string input dialogue panel).
  2. Verify that on paste, it does not propagate the paste node.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

@MFA-X-AI MFA-X-AI merged commit 85e98b7 into master Jun 1, 2023
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-dialogue-focus branch June 1, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant