Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Union Type Fixes + More Smart Link Fixes #350

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Aug 2, 2024

Description

This PR fixes the following:

  • fix union link logic if passed from non-literal: as node to node parameter linking is now fixed in 🐛 Smart Link Fixes #348 , the handling for Union needs to be addressed. This PR now properly parses each type in the Union (ie InArg[Union[str|int]]) and allows linking if one datatype mathces.
  • fix smart link not considering compulsory symbol: previously the compulsory [★] affects the smartlinking. Now this PR strips the ★ before matching.
  • fix smart link if using chain linking: as flow ports do not have data types, this PR properly handles it.
  • fix union symbol from not appearing in ports: previously Union type was internally set if there's a .. This PR properly recognizes it if type Union is passed.

References

#348

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  • ensure that the union link between nodes work as expected
  • ensure taht smart link properly works even with compulsory ports
  • ensure that smart link works if using chain linking
  • ensure that the union symbol appears on union types

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

github-actions bot commented Aug 2, 2024

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-union-typechecks

@MFA-X-AI MFA-X-AI merged commit 8aaf074 into master Aug 8, 2024
8 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-union-typechecks branch August 8, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant