-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add context menu #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I thought the open component function was broken again just to realize this pull request was made before it. After rebasing I confirmed that it's all good.
Really good groundwork for right click menu, didn't find any bugs.
Also appreciated the fix to the double click component, feels much easier to use now. :D
Description
This added a context menu for xircuits by right-clicking it.
Currently, the context menu have 6 options which are:
For
Edit
&Delete
, it's only enable when right-clicking a node. However,Edit
only works for Literal Node.Also, fix literal node editing when cancel is pressed or no input provided.
Pull Request Type
Type of Change
Tests
string
, press cancel or okTested on?
Notes
The
Shift+Right Click for Browser Menu
can't be removed as it's hardcoded in JupyterLab itself.