Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies to support PW 1.40.x #5

Merged
merged 2 commits into from
Dec 4, 2023
Merged

bump dependencies to support PW 1.40.x #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1411b4c
bump dependencies to support PW 1.40.x
bitcoder Dec 4, 2023
ca8b714
Merge branch 'main' into bump_dependencies
bitcoder Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 42 additions & 45 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"homepage": "https://github.com/Xray-App/playwright-junit-reporter",
"devDependencies": {
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@playwright/test": "^1.33.0",
"@playwright/test": "^1.40.1",
"@sinonjs/fake-timers": "^9.1.2",
"@types/node": "^18.7.23",
"@types/sinonjs__fake-timers": "^8.1.2",
Expand All @@ -52,12 +52,12 @@
"eslint-plugin-react-hooks": "^4.6.0",
"mock-fs": "^5.1.4",
"nyc": "^15.1.0",
"playwright": "^1.33.0",
"playwright": "^1.40.1",
"playwright-test-coverage": "^1.2.0",
"prettier": "^2.7.1",
"rimraf": "^5.0.0",
"source-map-support": "^0.5.21",
"typescript": "^5.0.2",
"typescript": "^5.3.2",
"ws": "^8.13.0",
"xml2js": "^0.5.0"
},
Expand Down
12 changes: 5 additions & 7 deletions tests/playwright-test-fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import type { JSONReport, JSONReportSpec, JSONReportSuite, JSONReportTest, JSONR
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
import { rimraf, PNG } from 'playwright-core/lib/utilsBundle';
import { promisify } from 'util';
import { PNG } from 'playwright-core/lib/utilsBundle';
import { removeFolders } from 'playwright-core/lib/utils';
import type { CommonFixtures, CommonWorkerFixtures, TestChildProcess } from './config/commonFixtures';
import { commonFixtures } from './config/commonFixtures';
import type { ServerFixtures, ServerWorkerOptions } from './config/serverFixtures';
Expand All @@ -36,8 +36,6 @@ import { expect } from './stable-test-runner';
import { test as base } from './stable-test-runner';
*/

export const removeFolderAsync = promisify(rimraf);

export type CliRunResult = {
exitCode: number,
output: string,
Expand Down Expand Up @@ -114,7 +112,7 @@ async function runPlaywrightTest(childProcess: CommonFixtures['childProcess'], b
// eslint-disable-next-line prefer-const
let { exitCode, output } = await runPlaywrightCommand(childProcess, cwd, args, {
// PW_TEST_REPORTER: path.join(__dirname, '../../packages/playwright-test/lib/reporters/json.js'),
PW_TEST_REPORTER: path.join(__dirname, '../node_modules//@playwright/test/lib/reporters/json.js'),
PW_TEST_REPORTER: path.join(__dirname, '../node_modules/playwright/lib/reporters/json.js'),
// PW_TEST_REPORTER: path.join(__dirname, '../dist/index.js'),
PLAYWRIGHT_JSON_OUTPUT_NAME: reportFile,
...env,
Expand Down Expand Up @@ -268,7 +266,7 @@ export const test = base
const baseDir = await writeFiles(testInfo, files, true);
return await runPlaywrightTest(childProcess, baseDir, params, { ...env, PWTEST_CACHE_DIR: cacheDir }, options);
});
await removeFolderAsync(cacheDir);
await removeFolders([cacheDir]);
},

runWatchTest: async ({ childProcess }, use, testInfo: TestInfo) => {
Expand All @@ -280,7 +278,7 @@ export const test = base
return testProcess;
});
await testProcess?.kill();
await removeFolderAsync(cacheDir);
await removeFolders([cacheDir]);
},

runTSC: async ({ childProcess }, use, testInfo) => {
Expand Down
2 changes: 1 addition & 1 deletion tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"allowJs": true,
"checkJs": false,
"noEmit": true,
"moduleResolution": "node",
"moduleResolution": "Node16",
"target": "ESNext",
"strictNullChecks": false,
"strictBindCallApply": true,
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"target": "ESNext",
"module": "node16",
"moduleResolution": "node",
"moduleResolution": "Node16",
"sourceMap": false,
"outDir": "./dist",
"declaration": true,
Expand Down