Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename with_error_fn into when #15

Merged
merged 1 commit into from
Jul 4, 2022
Merged

refactor: rename with_error_fn into when #15

merged 1 commit into from
Jul 4, 2022

Conversation

wfxr
Copy link
Contributor

@wfxr wfxr commented Jul 4, 2022

Rename with_error_fn into when.

Closes #11

Xuanwo
Xuanwo reviewed Jul 4, 2022
View reviewed changes
src/retry.rs Outdated Show resolved Hide resolved
src/retry.rs Outdated Show resolved Hide resolved
@wfxr wfxr force-pushed the refactor/rename-api branch from e89cd24 to ca0e4cf Compare July 4, 2022 15:21
@wfxr wfxr requested a review from Xuanwo July 4, 2022 15:23
Xuanwo
Xuanwo approved these changes Jul 4, 2022
View reviewed changes
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Xuanwo Xuanwo merged commit d0317cf into Xuanwo:main Jul 4, 2022
@wfxr wfxr deleted the refactor/rename-api branch July 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pick a more appropriate name for with_error_fn?
2 participants
@wfxr @Xuanwo