[Enhancement] Option to disable update messages

[Tempest-5ky]

Checks

• I confirm that I have searched for existing issues before reporting to avoid duplicate reporting.

Description

Hello!
The mod sending an "update is available" message in the discord channel every time the server restarts is quite annoying, and an option to disable that in the configs would be greatly appreciated!
Updating to the newest version isn't always possible, especially because the newest release (in 1.18.2) is causing a server crash and deadlock for us.

[Xujiayao]

Updating to the newest version isn't always possible, especially because the newest release (in 1.18.2) is causing a server crash and deadlock for us.

What crash and deadlock? Is it #55 ?

[Tempest-5ky]

Yes, I’m getting the exact same error!

…

On Thu, 30 Jun 2022 at 6:49 PM, Jason Xu ***@***.***> wrote: Updating to the newest version isn't always possible, especially because the newest release (in 1.18.2) is causing a server crash and deadlock for us. What crash and deadlock? Is it #55 <#55> ? — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXU7W7UOGZAHHHGR4B6OLFLVRZFBRANCNFSM52KFMQAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Xujiayao]

Then it has been fixed in latest build.

[Tempest-5ky]

Great, thank you so much! The suggestion to toggle the update message still stands though, it would be a useful feature for sure, especially if similar issues arise in the future.

…

On Thu, 30 Jun 2022 at 11:04 PM, Jason Xu ***@***.***> wrote: Then it is fixed in latest build. — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXU7W7TTJMTT5YUDJQMWYADVR2C5VANCNFSM52KFMQAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Xujiayao]

There was a similar issue (#22) considering that checking for updates was annoying, and it was possible to turn off admin notifications after that. Well, I still won't provide an option to turn off auto-checking for updates, as it is good practice to stay up to date, especially for a mod like MCDC, which is unstable and has frequent bug fixes.

However, I would change some logic:

@TypicalTropic
#54 (comment)

Our server host went down today and diagnosing it required restarting a couple of times and every time the server came up it posted the update.

Delay the check when starting the server by 1 hour. Enough time for you to diagnose with deleting MCDC config needed.

@Tempest-5ky
#52 (comment)

Especially if similar issues arise in the future.

@backanda
#54 (comment)

I restart the server once per day.

When MCDC found a new version update, the notification period would reduce to only once 48+ hours. The time is recorded in the config, so it is not sensitive to restarts. That would be enough time to fix crash issues and release a new version.

---

If you insist that you don't want to update, then I believe you have the ability to maintain MCDC and fix bugs yourself. Then please fork the repository yourself to delete the code about checking for updates :)

[secondfry]

Great mod, but:

If you insist that plugin should create messages vertically longer than computer screen including 2 embeds and untranslatable Chinese, can you at least make it so this messages would land into separate admin channel? Name it adminChannelId for example.

[secondfry]

Or lower the contents of update message to just one link without the embed, those who are interested would read changelogs themselves.

[Xujiayao]

Or lower the contents of update message to just one link without the embed, those who are interested would read changelogs themselves.

Good idea

[Xujiayao]

All issues re-examined:

Fixed in MCDC v2 stable release.